After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685950 - Save us context menu option downloads the link before a destination have been selected
Save us context menu option downloads the link before a destination have been...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 678610
 
 
Reported: 2012-10-11 10:49 UTC by Carlos Garcia Campos
Modified: 2013-02-20 14:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (2.96 KB, patch)
2012-10-11 10:52 UTC, Carlos Garcia Campos 		none Details | Review
Updated patch (2.88 KB, patch)
2013-01-04 10:12 UTC, Carlos Garcia Campos 		committed Details | Review

Description Carlos Garcia Campos 2012-10-11 10:49:56 UTC 
In WebKit2, downloads don't start on demand, there's no webkit_download_start. You request the web context to start a download and it returns a download object. So, as soon as you select save as, you will see the file chooser and a download already running (well, actually two downloads because of bug #678993) in the downloads bar. The location you choose from the file chooser won't have any effect because the download is already running with the default download destination.
Comment 1 Carlos Garcia Campos 2012-10-11 10:52:04 UTC 
Created attachment 226249 [details] [review]
Patch
Comment 2 Carlos Garcia Campos 2012-10-11 10:52:55 UTC 
This patch was already reviewed in bug #679366, see https://bugzilla.gnome.org/show_bug.cgi?id=679366#c4.
Comment 3 Carlos Garcia Campos 2013-01-04 10:12:23 UTC 
Created attachment 232717 [details] [review]
Updated patch

Updated after ephy download api changes
Comment 4 Xan Lopez 2013-02-14 18:02:07 UTC 
Review of attachment 232717 [details] [review]:

Looks good.