After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685919 - Make the screen shield look nicer
Make the screen shield look nicer
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.6.1
: 682547 682548 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-10 21:36 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-10-11 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenShield: Align notifications to the left, not the middle (3.18 KB, patch)
2012-10-10 21:36 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
screenShield: Add some padding between the clock and notifications box (1.71 KB, patch)
2012-10-10 21:36 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
theme: Make the notifications box match mockups better (1.52 KB, patch)
2012-10-10 21:36 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
screenShield: Remove erroneous top/bottom padding that may appear (1.66 KB, patch)
2012-10-10 21:36 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-10-10 21:36:43 UTC 
See patches. This makes it match the mockups more, and fixes
some ugly issuse with it.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-10-10 21:36:45 UTC 
Created attachment 226211 [details] [review]
screenShield: Align notifications to the left, not the middle

With different lengths of text in notifications, icons aren't
aligned and things look ugly. Put notifications on the left
for now.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-10 21:36:47 UTC 
Created attachment 226212 [details] [review]
screenShield: Add some padding between the clock and notifications box
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-10 21:36:50 UTC 
Created attachment 226213 [details] [review]
theme: Make the notifications box match mockups better

Adjust font sizes, spacing and padding, and add a box shadow
to the notifications box.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-10 21:36:52 UTC 
Created attachment 226214 [details] [review]
screenShield: Remove erroneous top/bottom padding that may appear

If there are either no resident or persistent notifications, we'll
add some spacing for those boxes that may contain nothing. Make them
invisible to remove the spacing for those elements. It's possible
that we may want to be smarter about this in StBoxLayout to remove
spacing for zero-sized actors, but today is not the day.
Comment 5 Allan Day 2012-10-10 21:45:13 UTC 
I'd love to see this land for 3.6.1; the lock screen notifications look quite broken right now.
Comment 6 Giovanni Campagna 2012-10-11 12:51:10 UTC 
Review of attachment 226211 [details] [review]:

Looks good
Comment 7 Giovanni Campagna 2012-10-11 12:52:30 UTC 
Review of attachment 226212 [details] [review]:

Can't you use padding on the #screenShieldClock?
(It's ok anyway)
Comment 8 Giovanni Campagna 2012-10-11 12:52:59 UTC 
Review of attachment 226213 [details] [review]:

Sure
Comment 9 Giovanni Campagna 2012-10-11 12:54:22 UTC 
Review of attachment 226214 [details] [review]:

It doesn't look like the best solution, but ok
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-10-11 12:54:54 UTC 
(In reply to comment #9)
> Review of attachment 226214 [details] [review]:
> 
> It doesn't look like the best solution, but ok

Do you have a better one?
Comment 11 Giovanni Campagna 2012-10-11 13:13:40 UTC 
(In reply to comment #10)
> (In reply to comment #9)
> > Review of attachment 226214 [details] [review] [details]:
> > 
> > It doesn't look like the best solution, but ok
> 
> Do you have a better one?

Not right now, so go for it.
We'll fix it later.
Comment 12 Allan Day 2012-10-11 14:35:16 UTC 
*** Bug 682547 has been marked as a duplicate of this bug. ***
Comment 13 Allan Day 2012-10-11 14:36:36 UTC 
*** Bug 682548 has been marked as a duplicate of this bug. ***
Comment 14 Jasper St. Pierre (not reading bugmail) 2012-10-11 15:26:17 UTC 
Attachment 226211 [details] pushed as b3cd46a - screenShield: Align notifications to the left, not the middle
Attachment 226212 [details] pushed as 955b550 - screenShield: Add some padding between the clock and notifications box
Attachment 226213 [details] pushed as d90bf5c - theme: Make the notifications box match mockups better
Attachment 226214 [details] pushed as cf0ae8f - screenShield: Remove erroneous top/bottom padding that may appear