Created attachment 226096 [details] [review]
properties: Switch to 'System' tab for VM under construction

Switch to 'System' tab automatically when going from wizard to
properties. The assumption here is that when users want to customize the
box before creation, its usually the system properties they want to edit.

Review of attachment 226096 [details] [review]:

Minor comment, but looks good

::: src/properties.vala
@@ +167,3 @@
+            current_page = (previous_ui_state == UIState.WIZARD) ? PropertiesPage.SYSTEM : PropertiesPage.LOGIN;
+        } else
+            current_page = PropertiesPage.LOGIN;

With bug #684233 fixed, 'machine' cannot be NULL there (?)

(In reply to comment #2)
> Review of attachment 226096 [details] [review]:
> 
> Minor comment, but looks good
> 
> ::: src/properties.vala
> @@ +167,3 @@
> +            current_page = (previous_ui_state == UIState.WIZARD) ?
> PropertiesPage.SYSTEM : PropertiesPage.LOGIN;
> +        } else
> +            current_page = PropertiesPage.LOGIN;
> 
> With bug #684233 fixed, 'machine' cannot be NULL there (?)

1. That bug is not exactly fixed but only worked around atm, i-e machine is null when creating non-VMs.
2. This null check is more testing if the machine is a LibvirtMachine and we'd want that even when bug#684233 is fixed as we don't want to switch to system tab for non-VMs.

Attachment 226096 [details] pushed as 40acaab - properties: Switch to 'System' tab for VM under construction