After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685652 - memory leak fixes
memory leak fixes
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-07 11:30 UTC by Pavel Vasin
Modified: 2012-10-08 07:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
individual-menu: fix another GeeIterator leak (802 bytes, patch)
2012-10-07 11:31 UTC, Pavel Vasin 		committed Details | Review
contact-search-dialog: fix GtkSizeGroup leak (1.01 KB, patch)
2012-10-07 11:31 UTC, Pavel Vasin 		committed Details | Review
empathy_theme_manager_dup_theme_name_from_path(): fix mem leaks (1.14 KB, patch)
2012-10-07 11:32 UTC, Pavel Vasin 		committed Details | Review
theme-manager: fix GList leak (1000 bytes, patch)
2012-10-07 11:32 UTC, Pavel Vasin 		committed Details | Review
empathy-spell: fix string leak (673 bytes, patch)
2012-10-07 11:32 UTC, Pavel Vasin 		committed Details | Review

Description Pavel Vasin 2012-10-07 11:30:44 UTC 
see patches
Comment 1 Pavel Vasin 2012-10-07 11:31:13 UTC 
Created attachment 225979 [details] [review]
individual-menu: fix another GeeIterator leak
Comment 2 Pavel Vasin 2012-10-07 11:31:36 UTC 
Created attachment 225980 [details] [review]
contact-search-dialog: fix GtkSizeGroup leak
Comment 3 Pavel Vasin 2012-10-07 11:32:17 UTC 
Created attachment 225981 [details] [review]
empathy_theme_manager_dup_theme_name_from_path(): fix mem leaks
Comment 4 Pavel Vasin 2012-10-07 11:32:39 UTC 
Created attachment 225982 [details] [review]
theme-manager: fix GList leak
Comment 5 Pavel Vasin 2012-10-07 11:32:59 UTC 
Created attachment 225983 [details] [review]
empathy-spell: fix string leak
Comment 6 Guillaume Desmottes 2012-10-08 07:48:23 UTC 
Review of attachment 225979 [details] [review]:

::: libempathy-gtk/empathy-individual-menu.c
@@ +483,3 @@
     }
+
+    g_object_unref (iter);

Indentation is wrong but I'll fix, thx!
Comment 7 Guillaume Desmottes 2012-10-08 07:51:19 UTC 
Review of attachment 225980 [details] [review]:

Nice catch!
Comment 8 Guillaume Desmottes 2012-10-08 07:52:00 UTC 
Review of attachment 225981 [details] [review]:

++
Comment 9 Guillaume Desmottes 2012-10-08 07:53:51 UTC 
Review of attachment 225982 [details] [review]:

++
Comment 10 Guillaume Desmottes 2012-10-08 07:55:34 UTC 
Review of attachment 225983 [details] [review]:

++
Comment 11 Guillaume Desmottes 2012-10-08 07:56:37 UTC 
Thanks a lot for all these fixed. They will be in the next 3.6 release.

Attachment 225979 [details] pushed as 59ea9e4 - individual-menu: fix another GeeIterator leak
Attachment 225980 [details] pushed as b46b9e3 - contact-search-dialog: fix GtkSizeGroup leak
Attachment 225981 [details] pushed as 3ca6b8a - empathy_theme_manager_dup_theme_name_from_path(): fix mem leaks
Attachment 225982 [details] pushed as f36171e - theme-manager: fix GList leak
Attachment 225983 [details] pushed as 9ad6ad6 - empathy-spell: fix string leak