GNOME Bugzilla – Bug 685201
Login screen - avatar image and password field are misaligned
Last modified: 2012-10-11 14:33:41 UTC
Created attachment 225480 [details] photograph The login screen that I get when first logging in (ie. not the one I get from the lock screen) has a quite obvious alignment problem - the user image (avatar) isn't vertically centered against the password field (see the attached photograph). Also, this initial login screen should have the same layout as the one you get from the lock screen, which has the password field spanning the width of the cancel and sign in buttons. We should try and get this fixed for 3.6.1, if possible.
Created attachment 225817 [details] [review] unlockDialog: Use a different style class Currently the unlock dialog uses the same style classes as the login screen, which breaks where login screen and unlock dialog use different layouts - for instance, the password prompt is located next to the user avatar on the former, but below avatar and name on the latter. In order to allow using different styles for each case, use a different top-level style class in the unlock dialog and share style explicitly.
Created attachment 225818 [details] [review] style: Fix alignment issue on login screen A style update for the unlock dialog in commit e0bb15e5 messed up the alignment of user avatar and password prompt in the login screen. Fix by only applying the style in question to the unlock dialog.
Don't the designs show that they should be the same in both places?
Created attachment 225830 [details] [review] loginDialog: Use the same prompt layout as the unlock dialog Currently the layout of the password prompt differs slightly between login dialog and unlock screen - for the former, the prompt is displayed next to the user avatar, replacing the user name, for the latter, it is diplayed below both avatar and name. I'm not sure what's the expected design here, so here's the alternative of moving the login screen closer to the unlock dialog. Definitively riskier (e.g. I could only test the "normal" password case), and requires a freeze break.
Created attachment 225831 [details] [review] loginDialog: Remove now unused functions
Created attachment 225839 [details] Screenshot of login screen with patch applied
Review of attachment 225830 [details] [review]: I was hoping we could reuse the UnlockDialog implementation, but I guess it isn't so. Looks fine regardless.
Review of attachment 225831 [details] [review]: ::: js/gdm/loginDialog.js @@ -217,3 @@ - - function() { - return item.fadeInName(); This isn't an "unused function". Squash with previous patch, please.
Are the older patches still needed?
It's either the first or the second pair of patches, depending on what the designers want.
(In reply to comment #10) > It's either the first or the second pair of patches, depending on what the > designers want. https://raw.github.com/gnome-design-team/gnome-mockups/master/system-lock-login-boot/login-password.png https://raw.github.com/gnome-design-team/gnome-mockups/master/system-lock-login-boot/unlock.png Take from that what you will.
Also, your username is gray in the screenshot. I assume you're going to fix that before you push.
Screenshot looks good to me, but probably needs a ui freeze request for 3.6.1
Created attachment 225886 [details] [review] loginDialog: Use the same prompt layout as the unlock dialog Updated style of username
Created attachment 225887 [details] [review] loginDialog: Remove now unused functions
Created attachment 225892 [details] [review] loginDialog: Sync :expanded better with user list visibility Now that we use a different text style for the username depending on whether the user list is expanded or not, changing the :expanded style before the actual transition looks disruptive. Adding the style right before fading in other items and removing it right after fading them out gives a better result.
Review of attachment 225886 [details] [review]: Sure.
Review of attachment 225887 [details] [review]: Yep.
Review of attachment 225892 [details] [review]: Makes sense.
*** Bug 663007 has been marked as a duplicate of this bug. ***
Did you ask the designers about this ?
If the avatar wasn't misaligned, I wouldn't mind not having the user name on the unlock screen and differing from the login dialog. But when given the choice now, having the layout be the same for unlock and login seems a better variant.
(In reply to comment #22) > But when given the choice now, having the layout be the same for unlock > and login seems a better variant. Good, so I was right in requesting a freeze break :-)
Attachment 225886 [details] pushed as 05f5fac - loginDialog: Use the same prompt layout as the unlock dialog Attachment 225887 [details] pushed as dc15df1 - loginDialog: Remove now unused functions Attachment 225892 [details] pushed as e8f96a6 - loginDialog: Sync :expanded better with user list visibility Pushing after RT approval.