After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685194 - Stopwatch layout
Stopwatch layout
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-10-01 10:17 UTC by Allan Day
Modified: 2013-01-05 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot and modified screenshot (184.22 KB, image/png)
2012-10-01 10:17 UTC, Allan Day
  Details
Fix stopwatch view (1.57 KB, patch)
2012-10-07 16:05 UTC, Maël Lavault
none Details | Review
Reset lap count after hitting reset button (1.04 KB, patch)
2012-10-07 16:12 UTC, Maël Lavault
committed Details | Review

Description Allan Day 2012-10-01 10:17:22 UTC
Created attachment 225478 [details]
screenshot and modified screenshot

The new list for lap times has created some issues with the layout of the stopwatch view. The stopwatch itself is squeezed in and doesn't appear central enough to the UI.

To fix this, the lap list can be made to be smaller, giving more padding and focus to the stopwatch and buttons.

The attached image shows a screenshot on the left with a modified version on the right.
Comment 1 Maël Lavault 2012-10-07 16:05:04 UTC
Created attachment 225991 [details] [review]
Fix stopwatch view

Here is a patch. I made the lap widget large enough to display 4 laps before displaying a scrollbar.
Comment 2 Maël Lavault 2012-10-07 16:12:02 UTC
Created attachment 225992 [details] [review]
Reset lap count after hitting reset button

I discovered that the lap count was not reseted properly after hitting reset button. So here is a small fix.
Comment 3 Paolo Borelli 2012-10-07 17:31:27 UTC
Review of attachment 225992 [details] [review]:

Thanks. I committed the bugfix.

For the alignment patch, I tried to play a bit with the values, but I didn't like the outcome a lot, so I have not committed it yet. Having just 4 lines for laps seems really little to me... looking at the other clocks app the laps list takes about 1/2 of the stopwatch view.

Summing things up we have these things competing for the vertical space

 * the 64pt font size of the label (to be the same of other pages)
 * the buttons (same size of other pages)
 * 24 pixels between label and buttons
 * margins above the labels and below the buttons > 24 to reflect Allan's mockup
 * At least 5 lines of laps

Each of the above items makes sense on its own, but the total does not fit our vertical space budget... what do give up?
Comment 4 Maël Lavault 2012-10-07 19:39:54 UTC
I think for common use cases 4 laps seems enough no ? Most of the time peoples won't see the scrollbar, and if they are, it's not such a big deal.
Comment 5 Paolo Borelli 2012-10-07 20:50:17 UTC
I do not agree, I think for the user it is very frustrating if there is a lot of empty space and yet he is forced to use the scrollbar. If you look at other stopwatch apps the time display take the miniminal required space at the top and the rest of the space is left for the list of laps. 

Also with just 4 lines (which take less than 1/2 of the page) I think it looks pretty unbalanced.
Comment 6 Maël Lavault 2012-10-07 21:44:00 UTC
So maybe in this case we need to revisit the whole design of stopwatch view no ?
Comment 7 Paolo Borelli 2012-10-08 08:01:01 UTC
That sounds a bit radical... at the moment I think the stopwatch is the most complete of the the four :-)

We just need to decide how to tweak things... we can also simply decided to make the default size of the app a bit bigger
Comment 8 Paolo Borelli 2013-01-05 14:29:13 UTC
I have tweaked the whole window size and then added more padding in the stopwatch. I think it looks ok now.