GNOME Bugzilla – Bug 685156
Notifications from message tray prevent panel buttons to trigger properly
Last modified: 2012-10-11 12:30:11 UTC
To reproduce: Click into some notification of the message tray . Then the pop-up bubble is shown. Click in some top panel button. Then you see that the panel button is triggered and one second after, the notification from the message tray is triggered again, instead of close the pop-up bubble and trigger the panel button. This not happens in gnome-shell 3.4, so it is a regression.
And, this only happens in the overview mode.
Created attachment 225894 [details] [review] messageTray: Reset summary after loosing focus to outside actor Currently when the summary boxpointer is ungrabbed automatically because the keyboard focus was moved outside the message tray (for instance by selecting the overview search entry or opening the right-click menu of a dash item), after the popup is hidden _updateState() will grab focus and show the popup again. Work around this by unsetting the clicked summary item when loosing focus to an actor outside the message tray.
Review of attachment 225894 [details] [review]: Looks good.
I don't necessarily agree. Why does "_updateState() grab focus and show the popup again"? (also, s/loosing/losing/g)
(In reply to comment #4) > I don't necessarily agree. Why does "_updateState() grab focus and show the > popup again"? It is how the tray works - if a summary icon is clicked, we set a couple of properties and call _updateState()[0], which then shows the boxpointer as appropriate[1]. So we need to unset those properties when we are done with the boxpointer - outside the overview this is done when hiding the tray[2] (which we do after dismissing the boxpointer). (Note that we cannot just unset clickedSummaryItem etc unconditionally, as the ungrab might be a result of clicking a different summary item or clicking with a different button) [0] http://git.gnome.org/browse/gnome-shell/tree/js/ui/messageTray.js#n1781 [1] http://git.gnome.org/browse/gnome-shell/tree/js/ui/messageTray.js#n2000 [2] http://git.gnome.org/browse/gnome-shell/tree/js/ui/messageTray.js#n1934
Attachment 225894 [details] pushed as 5bfcc539 - 'messageTray: Reset summary after losing focus to outside actor'