After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684984 - No focus rendering for Icon Views in SELECTION_NONE mode
No focus rendering for Icon Views in SELECTION_NONE mode
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkIconView
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-09-27 17:19 UTC by Alexander Larsson
Modified: 2012-09-27 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
iconview: Render focus even in non-selected items (1.21 KB, patch)
2012-09-27 17:23 UTC, Alexander Larsson 		committed Details | Review

Description Alexander Larsson 2012-09-27 17:19:57 UTC 
Gnome-boxes uses an IconView in SELECTION_NONE mode, which means the selection is never rendered. This works ok as clicking should immediately launch.
However, with the current code it also means that the focus rectangle is never rendered so keyboard navigation, while working, is not very useful.

In fact, keyboard navigation is also broken in the normal mode if you move around without changing the selection (hold down ctrl), as it then only shows the focus rect when inside the selected icon.
Comment 1 Alexander Larsson 2012-09-27 17:23:02 UTC 
Created attachment 225273 [details] [review]
iconview: Render focus even in non-selected items

This is needed for the SELECTION_NONE mode where nothing is ever
selected, but its also needed for CTRL-<key> keynav that moves the
focus without changing the selection.
Comment 2 Benjamin Otte (Company) 2012-09-27 17:38:56 UTC 
Comment on attachment 225273 [details] [review]
iconview: Render focus even in non-selected items

Looks right to me.
Comment 3 Alexander Larsson 2012-09-27 17:41:33 UTC 
Attachment 225273 [details] pushed as ecd84fa - iconview: Render focus even in non-selected items