After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684696 - gnucash-docs: make [dist]check should run xmllint -valid -noout on */*/gnucash-*.xml
gnucash-docs: make [dist]check should run xmllint -valid -noout on */*/gnucas...
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
git-master
Other All
: Normal enhancement
: ---
Assigned To: Derek Atkins
Christian Stimming
Depends on:
Blocks:
 
 
Reported: 2012-09-24 03:32 UTC by Frank H. Ellenberger
Modified: 2018-06-29 23:10 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Frank H. Ellenberger 2012-09-24 03:32:02 UTC
I was really surprised:
 Before I commited r22417, I run all make checks and got no errors.
 Yelp 3.2.1 had no problems to render the page
 Later I run xmllint manually and found 2 errors.

So I think, we should run xmllint -valid -noout on */*/gnucash-*.xml, if  make check or distcheck is called.

Any objections?

What is to do?

1. configure.in needs a section:
dnl
dnl Check for xmllint
dnl
AC_PATH_PROG(XMLLINT, xmllint)
if test -z "$XMLLINT"; then
  AC_MSG_ERROR([xmllint not found, perhaps you should install the libxml2 package ?])
fi

Note: according README this is no new dependency, but until now unchecked.
Question: Are there distries out with other naming conventions?
Nice Sideeffect: I compared configure.in with http://wiki.gnucash.org/wiki/Translation#Prerequisite and gnucash-docs/README and synced them [22422].

2. the makefile magic:
Here am I lost. I don't know, where to add the check and need some help.

PS: On the screen enter_bug.cgi I don't see a button, to assign the bug to myself. All the stuff below Description/Comment and Attachment is missing.
Comment 1 Frank H. Ellenberger 2013-12-27 01:10:30 UTC
2. r23533
1. r23540
committed on trunk

For only one further 2.4 release there is no need to backport.
Comment 2 Frank H. Ellenberger 2013-12-27 01:21:23 UTC
Dupe of 688579
Comment 3 John Ralls 2018-06-29 23:10:51 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=684696. Please update any external references or bookmarks.