After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684627 - "Remove from favourites" tooltip sticks after removing an application
"Remove from favourites" tooltip sticks after removing an application
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-22 16:18 UTC by Dylan McCall
Modified: 2012-10-15 21:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: Reset show-apps label on drag-end (926 bytes, patch)
2012-10-15 21:14 UTC, Florian Müllner 		committed Details | Review

Description Dylan McCall 2012-09-22 16:18:56 UTC 
Steps to reproduce:
 - Open the overview
 - Note the tooltip for the Show Applications button (Should be "Show Applications").
 - Drop a favourite application over that button. The tooltip will have expanded, saying "Remove from Favourites"
 - The tooltip is still "Remove from Favourites"

The tooltip only sticks like this when you remove an application. If you drag something over the button and then go somewhere else, it correctly changes back to "Show Applications".
Comment 1 Florian Müllner 2012-10-15 21:14:00 UTC 
Created attachment 226507 [details] [review]
dash: Reset show-apps label on drag-end

Currently the label for the show-apps button is only updated during
drag operations, so after an item is successfully dropped on the
button, the label will still read "Remove from Favorites".
Fix this by resetting the label on drag-end.

Sorry, I meant to attach that earlier and forgot ...
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-15 21:21:29 UTC 
Review of attachment 226507 [details] [review]:

Looks good.
Comment 3 Florian Müllner 2012-10-15 21:22:52 UTC 
Attachment 226507 [details] pushed as cf58a7e - dash: Reset show-apps label on drag-end