After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684619 - dash: uneven padding at the top / bottom of the dash
dash: uneven padding at the top / bottom of the dash
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.6.1
: 685140 685427 686289 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-22 12:34 UTC by Volker Sobek (weld)
Modified: 2012-10-17 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: missing padding at the top (42.10 KB, image/png)
2012-09-22 12:34 UTC, Volker Sobek (weld) 		  Details
dash: Make padding even on the top/bottom of the dash (1.93 KB, patch)
2012-09-22 17:39 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
dash: Make padding even on the top/bottom of the dash (1.93 KB, patch)
2012-09-22 18:30 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Volker Sobek (weld) 2012-09-22 12:34:47 UTC 
Created attachment 224973 [details]
dash: missing padding at the top

See attached screen-shot.

This must be some kind of regression. The padding at the bottom of the dash is still fine.
Comment 1 Volker Sobek (weld) 2012-09-22 12:42:48 UTC 
Doing some measuring it turns out that the padding at the bottom of the dash is actually too big, so the padding missing at the top might be what's too much at the bottom, as if the vertical position of all items in the dash is too high.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-09-22 17:39:58 UTC 
Created attachment 224988 [details] [review]
dash: Make padding even on the top/bottom of the dash

When Florian landed the new dash container to show the all apps button
always, he got the math wrong -- he forgot to add padding around the
container, and used the height of the box to calculate a y2 position,
rather than the y2 position of the box.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-22 18:30:55 UTC 
Created attachment 224993 [details] [review]
dash: Make padding even on the top/bottom of the dash

When Florian landed the new dash container to show the all apps button
always, he got the math wrong -- he forgot to add padding around the
container, and used the height of the box to calculate a y2 position,
rather than the y2 position of the box.



I removed some code at the list minute by accident that broke the patch.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-09-25 09:34:01 UTC 
Can I please get a review on this? Florian?
Comment 5 Florian Müllner 2012-09-25 10:16:51 UTC 
Review of attachment 224993 [details] [review]:

Oh, so after the commit messages explains in detail how I'm too stupid to do math, I'm at least smart enough to review it? </sarcasm>

The code itself is fine.
Comment 6 Florian Müllner 2012-09-30 15:00:19 UTC 
*** Bug 685140 has been marked as a duplicate of this bug. ***
Comment 7 Matthias Clasen 2012-10-01 23:09:00 UTC 
freeze is over, so I guess this should be committed now, with a better commit message...
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-10-02 02:21:24 UTC 
q# Bug 684619 - dash: uneven padding at the top / bottom of the dash - UNCONFIRMED

Attachment 224993 [details] pushed as 7206b61 - dash: Make padding even on the top/bottom of the dash
Comment 9 Florian Müllner 2012-10-03 18:38:25 UTC 
*** Bug 685427 has been marked as a duplicate of this bug. ***
Comment 10 Lapo Calamandrei 2012-10-17 12:24:01 UTC 
*** Bug 686289 has been marked as a duplicate of this bug. ***