GNOME Bugzilla – Bug 684573
Lock screen - shield should have a semi-transparent top bar and cover the standard black one
Last modified: 2012-11-21 12:11:44 UTC
The lock behaves like a shield overlaid on top of the existing view. When the shield slides down, it should cover the black top bar, maintaining the impression that it is obscuring the content below. The mockups also call for a semi-transparent panel to be used instead of the black top bar. See: https://raw.github.com/gnome-design-team/gnome-mockups/master/system-lock-login-boot/lock-no-messages.png
Also, note that the login screen shouldn't have the black top bar either: https://github.com/gnome-design-team/gnome-mockups/raw/master/system-lock-login-boot/unlock.png
Created attachment 224952 [details] [review] panelCorner: Only overlap panel if necessary The panel corners overlap the panel in order to hide the underline used for active buttons where it is supposed to arc downwards following the roundness of the corner. Unfortunately this prevents us from using a transparent panel background, as the overlapped area ends up with the wrong transparency. Work around this limitation by only overlapping the panel if there is a visible border.
Created attachment 224953 [details] [review] panel: Remove .in-overview style class The panel used to be styled differently in the overview, but nowadays this is just a left-over.
Created attachment 224954 [details] [review] sessionMode: Add panelStyle property The panel should change appearance according to the sessionMode, so add a new panelStyle sessionMode property which allows to specify a mode specific style class for the panel actors.
Created attachment 224955 [details] [review] theme: Style the panel differently according to mode
(In reply to comment #1) > Also, note that the login screen shouldn't have the black top bar either: > > https://github.com/gnome-design-team/gnome-mockups/raw/master/system-lock-login-boot/unlock.png Is there just a border sticking out in the middle no where when opening the menu for this one?
> Is there just a border sticking out in the middle no where when opening the > menu for this one? https://raw.github.com/gnome-design-team/gnome-mockups/master/system-lock-login-boot/unlock-menu.png
Created attachment 224971 [details] [review] theme: Style the panel differently according to mode Remove rounded corners in (un)lock- and login-screen as in the mockups - this means the panelCorner patch isn't necessary anymore to make this work.
UI changes => 3.7 stuff.
Created attachment 228159 [details] screenshot Looks good, Florian! A couple of minor issues: * the user name and icons need to be lighter * if possible, the bar would benefit from being a little bit taller
Created attachment 228171 [details] [review] style: Tweak panel style (In reply to comment #10) > * the user name and icons need to be lighter > * if possible, the bar would benefit from being a little bit taller Sure - something like that? Feel free to tweak to your liking (the last patch is obviously meant to be squashed later)
Looks good to me, and Jimmac says it's hot. :)
Created attachment 228174 [details] [review] theme: Style the panel differently according to mode OK, squashing the patches then ...
Review of attachment 228174 [details] [review]: ::: data/theme/gnome-shell.css @@ +513,3 @@ +#panel.unlock-screen .panel-button:hover, +#panel.lock-screen .panel-button:hover, +#panel.login-screen .panel-button:hover, Uh, we can't do something about this? A single shared style class maybe?
(In reply to comment #14) > +#panel.unlock-screen .panel-button:hover, > +#panel.lock-screen .panel-button:hover, > +#panel.login-screen .panel-button:hover, > > Uh, we can't do something about this? A single shared style class maybe? Only if we hook it up in sessionMode, which I think makes sense for a central component like the top bar, but not really for .panel-buttons. .unlock-screen and .login-screen are using the same style, though that'll only safe 6 lines ...
Review of attachment 228174 [details] [review]: This is fine with me.
What's the status of this?
More review needed...
Review of attachment 224952 [details] [review]: hack hack hack hack hack hack hack hack but sure, it's not like I have any better idea
Review of attachment 224953 [details] [review]: Sure, I guess.
Review of attachment 224954 [details] [review]: uh, OK
(In reply to comment #19) > Review of attachment 224952 [details] [review]: > > hack hack hack hack hack hack hack hack > > but sure, it's not like I have any better idea Well, as mentioned in comment #8, this patch is no longer required by the current design, so we could just leave it out ...
Attachment 224952 [details] pushed as a112bfd - panelCorner: Only overlap panel if necessary Attachment 224953 [details] pushed as c0f868d - panel: Remove .in-overview style class Attachment 224954 [details] pushed as 2511f60 - sessionMode: Add panelStyle property Attachment 228174 [details] pushed as f0f7165 - theme: Style the panel differently according to mode