After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684550 - Disk Image Mounter shouldn't be an app launcher
Disk Image Mounter shouldn't be an app launcher
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
3.10.1
Depends on: 702681
Blocks:
 
 
Reported: 2012-09-21 12:37 UTC by Allan Day
Modified: 2013-10-04 17:28 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6



Description Allan Day 2012-09-21 12:37:43 UTC
Only applications should have application launchers. The Disk Image Mounter isn't an application. The way to remove an application launcher is to uninstall the app, for example, but I can't uninstall the Disk Image Mounter.

Also, this functionality doesn't warrant that degree of exposure - it's not going to be useful to most users, and will get in their way.
Comment 1 Elad Alfassa 2012-09-21 12:39:23 UTC
Having it as an item in the Nautilus application menu would be better than having a desktop launcher, in my opinion.
Comment 2 Tomas Bzatek 2012-09-21 12:46:44 UTC
FYI, we also have "Archive mounter", a desktop file coming from gvfs, associated with common archive types. While gvfsd-archive can deal with various archiving formats contrary to ISO in this case, it's a completely different way of access.
Comment 3 Elad Alfassa 2012-09-21 12:57:48 UTC
Archive Mounter does not show in the application list, tho
Comment 4 David Zeuthen (not reading bugmail) 2012-09-21 13:07:59 UTC
(In reply to comment #0)
> Also, this functionality doesn't warrant that degree of exposure - it's not
> going to be useful to most users, and will get in their way.

This is really all you had to say [1]. Yes, we can make Disk Image Mounter disappear from the application menus since the main way people use it is by the MIME-type association - e.g. auto-launch it when double-clicking an .iso file.

But it's too late to do this for 3.6 (I've already rolled 3.6.0 tarballs) so let's target 3.8 with this.

[1] : the other paragraph was unnecessary and just flame-bait. I mean, claiming "it's not an app" is clearly non-sense since I had deliberately chosen Disk Image Mounter to be an application :-) ... the bit about uninstalling is also really weird especially as you can easily do 'yum remove gnome-disk-utility' ... yes, it will also remove Disks but that's just a packaging problem.
Comment 5 Allan Day 2012-09-21 16:40:30 UTC
(In reply to comment #4)
> (In reply to comment #0)
> > Also, this functionality doesn't warrant that degree of exposure - it's not
> > going to be useful to most users, and will get in their way.
> 
> This is really all you had to say [1]. Yes, we can make Disk Image Mounter
> disappear from the application menus since the main way people use it is by the
> MIME-type association - e.g. auto-launch it when double-clicking an .iso file.

That seems like a better approach indeed.

> But it's too late to do this for 3.6 (I've already rolled 3.6.0 tarballs) so
> let's target 3.8 with this.

Sad to hear that...

> [1] : the other paragraph was unnecessary and just flame-bait. I mean, claiming
> "it's not an app" is clearly non-sense since I had deliberately chosen Disk
> Image Mounter to be an application :-) ... the bit about uninstalling is also
> really weird especially as you can easily do 'yum remove gnome-disk-utility'
> ... yes, it will also remove Disks but that's just a packaging problem.

I don't think it is nonsense. We're trying to push a mental model that only apps live in the application grid. Here, an "app" means a few things:

 * Has a UI of its own, including a sovereign window and app menu (not just a dialog)
 * Can be independently installed and uninstalled
 * Provides its own functionality
 * Has a distinct name and application icon

Launchers that don't follow this model dilute the schema of what applications are, how they can be accessed, and how they behave.
Comment 6 David Zeuthen (not reading bugmail) 2012-09-26 16:39:48 UTC
I've added NoDisplay=true so app launchers won't show up in the shell etc.

 http://git.gnome.org/browse/gnome-disk-utility/commit/?id=bda6f367170f22f3b3fab596242059775eade726

This will be in 3.6.1.
Comment 7 David Zeuthen (not reading bugmail) 2013-06-30 19:39:07 UTC
Had to remove the NoDisplay=true for the 3.9.x version because of bug 702681. So reopening this bug and adding the new defect as a dependency.
Comment 8 David Zeuthen (not reading bugmail) 2013-10-04 17:28:12 UTC
This was fixed just before rolling the 3.10.0 release:

 https://git.gnome.org/browse/gnome-disk-utility/commit/?id=b33bc95a20101f6b91bf555e44ccb0718587c8cd