After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684490 - user accounts: reloading fails
user accounts: reloading fails
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-20 16:05 UTC by Matthias Clasen
Modified: 2012-09-21 07:21 UTC
See Also:
GNOME target: 3.6
GNOME version: ---

Attachments
shell: Rename current_panel to current_panel_box (2.21 KB, patch)
2012-09-20 19:17 UTC, Bastien Nocera 		committed Details | Review
shell: Fix reloading existing panel (1.93 KB, patch)
2012-09-20 19:18 UTC, Bastien Nocera 		none Details | Review
shell: Reuse existing panels when activated again (3.66 KB, patch)
2012-09-20 19:18 UTC, Bastien Nocera 		none Details | Review
shell: Pass args to existing panels (4.19 KB, patch)
2012-09-20 19:22 UTC, Bastien Nocera 		committed Details | Review
big gray rectangle (70.76 KB, image/png)
2012-09-21 07:21 UTC, Frederic Peters 		  Details

Description Matthias Clasen 2012-09-20 16:05:29 UTC 
Click the avatar in the user menu.
User panel comes up and the user list is populated.
Click the avatar again.
Now the user list is empty :-(
Comment 1 Bastien Nocera 2012-09-20 19:17:53 UTC 
Created attachment 224852 [details] [review]
shell: Rename current_panel to current_panel_box

So that we can use current_panel for the current panel, not
for the container parent of the panel.
Comment 2 Bastien Nocera 2012-09-20 19:18:03 UTC 
Created attachment 224853 [details] [review]
shell: Fix reloading existing panel

The panel needs to be destroyed and disposed of properly first,
otherwise bizarre problems will start occuring.
Comment 3 Bastien Nocera 2012-09-20 19:18:13 UTC 
Created attachment 224854 [details] [review]
shell: Reuse existing panels when activated again

Instead of destroying and recreating the panel, we'll reuse
the panel, and set the new argv (usually to switch pages).
Comment 4 Bastien Nocera 2012-09-20 19:22:03 UTC 
Created attachment 224855 [details] [review]
shell: Pass args to existing panels

When re-activating the same panel, we could destroy and recreate the
panel, or better reuse the panel, and set the new argv
(usually to switch pages).
Comment 5 Bastien Nocera 2012-09-20 19:28:42 UTC 
For GNOME 3.6, we can either go for:
- attachment 224853 [details] [review] before 3.6
- attachment 224854 [details] [review] after 3.6

or easier:
attachment 224855 [details] [review] before 3.6.

For both, the sed job in attachment 224852 [details] [review] needs to go in.
Comment 6 Matthias Clasen 2012-09-20 19:58:01 UTC 
(In reply to comment #5)
> For GNOME 3.6, we can either go for:
> - attachment 224853 [details] [review] before 3.6
> - attachment 224854 [details] [review] after 3.6
> 
> or easier:
> attachment 224855 [details] [review] before 3.6.
> 
> For both, the sed job in attachment 224852 [details] [review] needs to go in.


The 'easier' patch looks less scary to me.
Comment 7 Bastien Nocera 2012-09-20 20:03:48 UTC 
(In reply to comment #6)
> The 'easier' patch looks less scary to me.

Let's do that then.
Comment 8 Bastien Nocera 2012-09-20 20:59:05 UTC 
Attachment 224852 [details] pushed as ab435aa - shell: Rename current_panel to current_panel_box
Attachment 224855 [details] pushed as 876d41b - shell: Pass args to existing panels
Comment 9 Frederic Peters 2012-09-21 07:21:06 UTC 
Created attachment 224897 [details]
big gray rectangle

It doesn't fix the issue completely, some times I get a dark gray rectangle instead of the menu content. (see screenshot).
Comment 10 Frederic Peters 2012-09-21 07:21:57 UTC 
Oops, wrong bug, meant that for bug 681676.