After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684473 - Settings menuitems visible on the login screen
Settings menuitems visible on the login screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-20 12:48 UTC by Matthias Clasen
Modified: 2012-09-20 18:04 UTC
See Also:
GNOME target: 3.6
GNOME version: ---

Attachments
popupMenu: Set initial visibility of settings items (1.16 KB, patch)
2012-09-20 14:06 UTC, Florian Müllner 		committed Details | Review

Description Matthias Clasen 2012-09-20 12:48:36 UTC 
I see 'Sound Settings' and all the other settings menuitems, as well as 'Open calendar'. Those are not supposed to be visible on the login screen.
Comment 1 Florian Müllner 2012-09-20 14:06:56 UTC 
Created attachment 224837 [details] [review]
popupMenu: Set initial visibility of settings items

With the recent session mode changes, the visibility of settings
items is now only set on sessionMode::updated - while the signal
is emitted when the session mode is initialized, settings items
that are added after that are visible regardless of the allowSettings
setting until the next sessionMode::updated signal is received.
Fix this by explicitly setting the initial visibility of settings
items.


So yet another regression from the sessionMode refactoring ...
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-09-20 15:30:55 UTC 
Review of attachment 224837 [details] [review]:

OK.
Comment 3 Matthias Clasen 2012-09-20 17:32:26 UTC 
release team approval 1 of 2 from me
Comment 4 André Klapper 2012-09-20 18:03:12 UTC 
release team approval 2 of 2
Comment 5 Florian Müllner 2012-09-20 18:04:21 UTC 
Attachment 224837 [details] pushed as e8ebe4d - popupMenu: Set initial visibility of settings items