After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684458 - alt-tab doesn't block message tray dwell
alt-tab doesn't block message tray dwell
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-20 11:28 UTC by Matthias Clasen
Modified: 2012-09-22 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Don't show when in 'modalMode' (958 bytes, patch)
2012-09-20 22:33 UTC, drago01 		needs-work Details | Review
messageTray: Clean up commented code a bit (1.19 KB, patch)
2012-09-20 22:41 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
messageTray: Don't open the tray from a dwell if we're in a modal grab (960 bytes, patch)
2012-09-20 22:41 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
messageTray: Don't open the tray from a dwell if we're in a modal grab (985 bytes, patch)
2012-09-22 13:57 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Matthias Clasen 2012-09-20 11:28:26 UTC 
rest your mouse at the bottom edge.
hit alt-tab, and tab around for a while.
suddenly, the message tray jumps out at you.
I think a mode like the alt-tab popup should inhibit that.
Comment 1 Matthias Clasen 2012-09-20 11:29:10 UTC 
Same for polkit dialogs and the like
Comment 2 drago01 2012-09-20 22:33:07 UTC 
Created attachment 224874 [details] [review]
messageTray: Don't show when in 'modalMode'

When alt-Tab, the workspace switcher, a PK dialog or anything similar is
open we should not show the messagetry as this would result
into a rather weird state.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-20 22:36:06 UTC 
Review of attachment 224874 [details] [review]:

Did you test this at all? toggleAndNavigate is not used for dwell.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-09-20 22:41:34 UTC 
Created attachment 224875 [details] [review]
messageTray: Clean up commented code a bit

Since we changed the grabHelper.grab call to be in a conditional,
it's been a little clear what the comment has been referring to.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-09-20 22:41:36 UTC 
Created attachment 224876 [details] [review]
messageTray: Don't open the tray from a dwell if we're in a modal grab

If we're in an alt-tab popup or modal dialog, we shouldn't pop up the tray
at all.
Comment 6 drago01 2012-09-21 11:56:34 UTC 
Review of attachment 224876 [details] [review]:

::: js/ui/messageTray.js
@@ +2030,2 @@
     _showTray: function() {
+        if (Main.modalCount > 0) {

This has to be "Main.modalCount > 0 && !Main.overview.visible" otherwise the try won't show up in the overview.
Comment 7 drago01 2012-09-21 11:57:22 UTC 
Review of attachment 224875 [details] [review]:

OK.
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-09-22 13:57:40 UTC 
Created attachment 224977 [details] [review]
messageTray: Don't open the tray from a dwell if we're in a modal grab

If we're in an alt-tab popup or modal dialog, we shouldn't pop up the tray
at all.
Comment 9 drago01 2012-09-22 14:53:32 UTC 
Review of attachment 224977 [details] [review]:

Looks good, fine to push with RT approval.
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-09-22 18:39:49 UTC 
Attachment 224875 [details] pushed as 7df7cd0 - messageTray: Clean up commented code a bit
Attachment 224977 [details] pushed as a87ba46 - messageTray: Don't open the tray from a dwell if we're in a modal grab