GNOME Bugzilla – Bug 684452
message tray: no keynav into the context menu
Last modified: 2014-11-03 18:18:50 UTC
Open the tray with Super-M. Hit the Menu key to pop up the Open/Remove menu. There is no way to activate items in the menu with the keyboard. I would expect up-arrow to keynav into the menu, in this state.
Tab works here, but it's definitively unexpected. Worse, when navigating the menu, the Down handling for the notification (pop down) is processed before the one for keynav in the menu (move focus down).
Created attachment 224828 [details] [review] messageTray: Only handle Down arrow on summary boxpointer
Created attachment 224829 [details] [review] messageTray: Move focus to menu when triggered by keybinding
Attached patches work around the issues noted, but I suspect that the underlying issue is that we expect the "menu" to look and behave like a menu, but we are not actually using PopupMenu ... (obviously out of scope at this point)
Comment on attachment 224828 [details] [review] messageTray: Only handle Down arrow on summary boxpointer Grrr, breaks Down arrow where we want it to work ...
Created attachment 224869 [details] [review] messageTray: Only handle Down arrow on left-click For the right-click menu, arrow keys should navigate inside the menu, not close the boxpointer. Not pretty, but it works ...
(In reply to comment #4) > Attached patches work around the issues noted, but I suspect that the > underlying issue is that we expect the "menu" to look and behave like a menu, > but we are not actually using PopupMenu ... (obviously out of scope at this > point) Giovanni had a patch that would introduce a PopupMenuEmbed, which was a PopupMenu that could be stuffed into something else like a BoxPointer.
Do we want this for 3.6.1?
(In reply to comment #8) > Do we want this for 3.6.1? I think we'd want to do the correct fix for this regardless, which would mean some form of PopupMenuEmbed. CCing Giovanni
I'd say at this point this depends very much on the intrusiveness of the correct fix.
Created attachment 226383 [details] [review] Message Tray: extend right click menus to be real PopupMenus Introduce a new PopupMenuEmbed class that shares positioning and focus navigation code with PopupMenu, and use that to build the right click menu for message tray sources. Here it is the rebased PopupMenuEmbed patch. It's only partially tested, so I'm not very confident in stuffing it in 3.6.1.
Review of attachment 226383 [details] [review]: Yikes. I'm not sure why the buildRightClickMenu changes are needed, and I'd like to see the introduction of PopupMenu split out.
(In reply to comment #12) > Review of attachment 226383 [details] [review]: > > Yikes. I'm not sure why the buildRightClickMenu changes are needed, and I'd > like to see the introduction of PopupMenu split out. Well, it was not meant for review, it was just a code dump of something I wrote long ago. I was expecting Florian to improve on it.
Do we want this for 3.8?
Ping, some users were pinging us in relation with this bug on IRC (specifically using as example the device icon, and the list of devices available) . Taking into account that the patch uploaded was written against 3.8 probably is already obsolete. Could someone confirm at least that?
I no longer have the patch in my tree and keynav works here, so tentatively closing as obsolete.
(Part of it has been handled by bug 735614, I'm too lazy to look up any other changes that made it work)
Hmmm. Looks like maybe it's just limited to removable device? I see no way to activate the eject button in the pop-up associated with that notification tray item.
(In reply to comment #18) > Hmmm. Looks like maybe it's just limited to removable device? I see no way to > activate the eject button in the pop-up associated with that notification tray > item. That may very well be possible. I only tested the context menu (<shift>F10) which is what the attached patches were supposed to fix.
Understood. Since other message tray items seem to be keyboard navigable, I opened bug 739588 for the removable device issue.