After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684406 - RAID / disk-enclosure icon
RAID / disk-enclosure icon
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jakub Steiner
Jakub Steiner
Depends on:
Blocks:
 
 
Reported: 2012-09-19 22:03 UTC by David Zeuthen (not reading bugmail)
Modified: 2012-12-06 22:02 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Zeuthen (not reading bugmail) 2012-09-19 22:03:26 UTC
For GNOME 3.8, Disks will include support for Linux Software RAID (aka MD-RAID). I am currently using an icon that looks like an enclosure for this

 http://people.freedesktop.org/~david/gnome-disks-mdraid-20120919-1.png

and am currently shipping that icon with the gnome-disk-utility tarball. I originally got the icon from Jimmac and I think he has the sources for it.

 http://git.gnome.org/browse/gnome-disk-utility/tree/data/icons?h=wip/mdraid

However, for use in GVfs, we need the icon to be in gnome-icon-theme since GVfs will start returning named icons for objects representing the MD-RAID array. Since these icons will show up in the file chooser and Files, we are also going to need a symbolic version of the icon. I suggest to use the name 'disk-enclosure' for this icon.
Comment 1 Jakub Steiner 2012-09-20 11:14:16 UTC
I'm afraid I'm not the author. Lapo? Do you have the sources for this one?
Comment 2 David Zeuthen (not reading bugmail) 2012-09-20 14:02:33 UTC
(In reply to comment #1)
> I'm afraid I'm not the author. Lapo? Do you have the sources for this one?

My bad, this icon was done by Mike Langlie when he was at Red Hat (he left a while ago). I'm not sure the sources (Photoshop format, I think) exist anymore, but if you want I can try and find them?
Comment 3 Jakub Steiner 2012-09-20 15:00:25 UTC
If it's Photoshop/bitmap, it's not really very useful. We'll redraw it.
Comment 4 David Zeuthen (not reading bugmail) 2012-09-20 15:50:40 UTC
(In reply to comment #3)
> If it's Photoshop/bitmap, it's not really very useful.

The only thing I got from Mike was the SVG file which is already in git in data/icons/scalable (see comment 0).

> We'll redraw it.

Sounds good to me too - thanks!
Comment 5 David Zeuthen (not reading bugmail) 2012-11-28 18:49:54 UTC
Hi, any update on this? Btw, I've changed my view on the naming. Instead of disk-enclosure (which I think we want to reserve for physical disk enclosures and not RAID stuff), I think it should be

 drive-multidisk

this way we can always add

 drive-multidisk-raid
 drive-multidisk-raid-level1
 drive-multidisk-raid-level5
 drive-multidisk-raid-level6
 drive-multidisk-raid-level10
 drive-multidisk-btrfs
 drive-multidisk-btrfs-singleparity
 drive-multidisk-btrfs-dualparity

and so on if we decide we want more detail (I totally don't think we do but I like to keep the door open). I would also like to ask for a symbolic icon, e.g. drive-multidisk-symbolic so it looks right in Files and the File Chooser.

Thanks!
Comment 7 David Zeuthen (not reading bugmail) 2012-11-28 19:22:07 UTC
(In reply to comment #6)
> http://www.actsofvolition.com/archive/2009/july/garrityslawof

I disagree that there's no "obvious visual metaphor" for RAID arrays - it's clearly a box filled with disk drives. Anyway, I'll just continue to ship the existing icon in the gnome-disk-utility package.
Comment 8 Jakub Steiner 2012-11-28 19:50:46 UTC
You'll get drive-multidisk in a few minutes. I was referring to all the kinds of raid arrays. You'd essentially be duplicating a label by sticking a badge on it or something along those lines.

Personally I'd go for one generic icon for these.
Comment 9 David Zeuthen (not reading bugmail) 2012-11-28 20:17:00 UTC
(In reply to comment #8)
> You'll get drive-multidisk in a few minutes.

Great, thanks.

> I was referring to all the kinds
> of raid arrays. You'd essentially be duplicating a label by sticking a badge on
> it or something along those lines.
> 
> Personally I'd go for one generic icon for these.

Yeah, I just wanted to leave it open in the icon naming spec.
Comment 10 David Zeuthen (not reading bugmail) 2012-11-28 20:53:22 UTC
I've now changed udisks and gnome-disk-utility to use this new icon name. With the latest g-i-t it looks like this:

http://people.freedesktop.org/~david/gnome-disks-new-raid-icon.png

Thanks a bunch!
Comment 11 David Zeuthen (not reading bugmail) 2012-12-06 19:01:12 UTC
Btw, is it possible to get a symbolic icon too? Right now (with udisks2 and gvfs tip-of-tree), it looks like this with the Files application

 http://people.freedesktop.org/~david/gnome-missing-symbolic-raid-icon.png

The name should be drive-multidisk-symbolic. Thanks.
Comment 12 Jakub Steiner 2012-12-06 22:02:03 UTC
Added to gnome-icon-theme-symbolic master. Not very keen on it, but better than nothing.