GNOME Bugzilla – Bug 684357
Improve context menu in chat window
Last modified: 2012-12-26 08:55:14 UTC
When you right click in a chat window you have a different context menu depending on the context: if no text is selected: - Back - Forward - Stop - Reload ( - Inspect Element) If text is selected: - Copy ( - Inspect Element) If the cursor is on a clickable link: - Open Link - Open Link in New Window - Download linked file - Copy Link location ( - Inspect Element) Most of those should be removed as they don't make sense here. This is with webkit 1.8.1
Actually those menus are only used if org.gnome.Empathy.conversation enable-webkit-developer-tools is set. The default menus are fine.
Created attachment 224737 [details] [review] empathy-webkit-util: coding style fixes
Created attachment 224738 [details] [review] factor out empathy_webkit_create_context_menu()
Created attachment 224739 [details] [review] export empathy_webkit_create_context_menu()
Created attachment 224740 [details] [review] depend on WebKitGtk+ 1.9.1 Needed for the WebKitWebView::context-menu signal.
Created attachment 224741 [details] [review] theme-adium: use WebKitWebView::context-menu signal That's now the proper way to implement our custom context menu.
Created attachment 224742 [details] [review] factor out empathy_webkit_show_inspector()
Created attachment 224743 [details] [review] add EMPATHY_WEBKIT_MENU_INSPECT flag
Created attachment 224744 [details] [review] theme-adium: use EMPATHY_WEBKIT_MENU_INSPECT We are now always using our own context menu even when the inspect menu item is displayed.
+1
Attachment 224737 [details] pushed as 8ad4b14 - empathy-webkit-util: coding style fixes Attachment 224738 [details] pushed as ea8cf1e - factor out empathy_webkit_create_context_menu() Attachment 224739 [details] pushed as 4894558 - export empathy_webkit_create_context_menu() Attachment 224740 [details] pushed as da413d0 - depend on WebKitGtk+ 1.9.1 Attachment 224741 [details] pushed as 5c9fcab - theme-adium: use WebKitWebView::context-menu signal Attachment 224742 [details] pushed as c4d4989 - factor out empathy_webkit_show_inspector() Attachment 224743 [details] pushed as 9db3e4d - add EMPATHY_WEBKIT_MENU_INSPECT flag Attachment 224744 [details] pushed as 968b743 - theme-adium: use EMPATHY_WEBKIT_MENU_INSPECT