After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684344 - grabHelper: Fix regression for dwelling with mouse down
grabHelper: Fix regression for dwelling with mouse down
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-19 03:12 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-09-19 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
grabHelper: Fix regression for dwelling with mouse down (3.89 KB, patch)
2012-09-19 03:12 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-09-19 03:12:34 UTC
See patch. Spotted by The_gull on IRC.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-09-19 03:12:36 UTC
Created attachment 224688 [details] [review]
grabHelper: Fix regression for dwelling with mouse down

b203a95a786af60257e55881c19b45192a0655b8 introduced a regression
where we forgot to bail out if the pushModal didn't succeed properly.
Comment 2 Giovanni Campagna 2012-09-19 10:57:10 UTC
Review of attachment 224688 [details] [review]:

Yes
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-09-19 11:10:44 UTC
Attachment 224688 [details] pushed as 2acb097 - grabHelper: Fix regression for dwelling with mouse down