GNOME Bugzilla – Bug 684340
app menu does nothing if the application is not responding
Last modified: 2012-12-25 17:45:42 UTC
The app menu does nothing if the application is not responding. This means it is hard to even quit the application. I guess at minimum we should be showing the not responding dialog thing or a Force Quit menu item or something.
Created attachment 232200 [details] [review] MetaWindow: add a public method for checking if the application is responding Add meta_window_check_alive(), which is a simple wrapper over meta_display_ping_window(), and takes care of showing the "Application is not responding dialog" if needed.
Created attachment 232201 [details] [review] Check that the application is responding when activating a window Currently, we ping windows only when attempting to delete them, but if the application is not responding, we want to show the dialog as soon as possible. Given that we cannot be passively notified that the window stopped responding with the current X11 protocol, a good workaround is to ping the window when activating it. If the window stops responding while active, it is expected the user will try to switch window or open the overview, and when coming back he'll get the failure dialog.
Created attachment 232202 [details] [review] Ping the active window when using the app menu Use the new meta_window_check_alive() to verify if the application is responding after the user activates an action from the app menu. This in particular restores the ability to force quit applications from the menu, even if the use a custom GMenu.
Review of attachment 232200 [details] [review]: Code looks good, I am not sure the name "check_alive" makes sense ... but can't really think of something better.
Review of attachment 232201 [details] [review]: Makes sense.
Review of attachment 232202 [details] [review]: LG.
Attachment 232200 [details] pushed as 57ff0f7 - MetaWindow: add a public method for checking if the application is responding Attachment 232201 [details] pushed as 6431abb - Check that the application is responding when activating a window
Attachment 232202 [details] pushed as ebd1bc8 - Ping the active window when using the app menu Thank you for the review, and Happy Holidays! :)