After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684098 - Inconsistent strings in nautilus and eog for setting background image
Inconsistent strings in nautilus and eog for setting background image
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
3.5.x
Other Linux
: Normal normal
: GNOME3.8
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-15 15:47 UTC by André Klapper
Modified: 2012-10-02 17:28 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
window: rename "Set as Desktop Background" -> "Set as Wallpaper" (1.08 KB, patch)
2012-09-17 14:46 UTC, Cosimo Cecchi 		none Details | Review
window: rename "Set as Desktop Background" -> "Set as Wallpaper" (1.20 KB, patch)
2012-09-17 14:48 UTC, Cosimo Cecchi 		accepted-commit_now Details | Review
window: rename "Set as Desktop Background" -> "Set as Wallpaper" (1.20 KB, patch)
2012-09-17 16:54 UTC, Cosimo Cecchi 		accepted-commit_after_freeze Details | Review

Description André Klapper 2012-09-15 15:47:36 UTC 
Files uses <gui>Set as Wallpaper</gui> in the right-click menu.
eog uses <guiseq><gui>Image</gui><gui>Set as Desktop Background</gui></guiseq>.

Please agree on using the same string (CC'ing eog maintainers).

Note: After fixing, gnome-user-docs/gnome-help/C/look-background.page needs an update.
Comment 1 Cosimo Cecchi 2012-09-17 14:46:38 UTC 
-> eog

I believe "Set as Wallpaper" is the best option, since we would like to de-emphasize the term "Desktop" in GNOME 3.
Reassigning to eog, since I have a patch.
Comment 2 Cosimo Cecchi 2012-09-17 14:46:53 UTC 
Created attachment 224514 [details] [review]
window: rename "Set as Desktop Background" -> "Set as Wallpaper"

To be consistent with Nautilus.
Comment 3 Cosimo Cecchi 2012-09-17 14:48:24 UTC 
Created attachment 224515 [details] [review]
window: rename "Set as Desktop Background" -> "Set as Wallpaper"

--

Missed the long description string.
Comment 4 Claudio Saavedra 2012-09-17 15:19:59 UTC 
Review of attachment 224515 [details] [review]:

Please ask for permission to break the freeze and push.
Comment 5 André Klapper 2012-09-17 15:33:22 UTC 
+	{ "ImageSetAsWallpaper", NULL, N_("Set as Wallpaper"),

I don't see a mnemonic in that string.
Comment 6 Cosimo Cecchi 2012-09-17 16:02:30 UTC 
(In reply to comment #5)
> +    { "ImageSetAsWallpaper", NULL, N_("Set as Wallpaper"),
> 
> I don't see a mnemonic in that string.

'S' is taken by "Save", 'W' is taken by "Open with"...suggestions?
Comment 7 André Klapper 2012-09-17 16:19:42 UTC 
Any that is not yet used. :) Does not have to be the first letter of a word, there can also be duplicates if there is no other option.
Comment 8 Cosimo Cecchi 2012-09-17 16:54:26 UTC 
Created attachment 224529 [details] [review]
window: rename "Set as Desktop Background" -> "Set as Wallpaper"

--

Now with a mnemonic
Comment 9 Felix Riemann 2012-09-18 15:37:25 UTC 
This will require updating the user docs as well.
If you manage to get a freeze break for both feel free to push.

I'm still out of house until at least 10pm CEST, so a release is unlikely to happen earlier.
Comment 10 Cosimo Cecchi 2012-09-18 17:56:46 UTC 
I asked for a freeze break now, let's see if it can make it in this release :)
Comment 11 Felix Riemann 2012-09-19 16:10:21 UTC 
Looks like they won't give us a break. :(
Thanks, for trying anyway. :)
Comment 12 Felix Riemann 2012-10-02 17:28:38 UTC 
And pushed to master:

commit cc958f1201e12dc0a634ffc45995dd53b4793b19
Author: Felix Riemann <>
Date:   Fri Sep 28 19:43:26 2012 +0200

    help: rename "Set as Desktop Background" -> "Set as Wallpaper"
    
    To match the recent UI string change.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684098

commit 166a24f31454e9b1169c235fe6fc2494d91f55f8
Author: Cosimo Cecchi <>
Date:   Mon Sep 17 10:43:51 2012 -0400

    window: rename "Set as Desktop Background" -> "Set as Wallpaper"
    
    To be consistent with Nautilus.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684098
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.