After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684084 - playbin: text-sink property behaviour
playbin: text-sink property behaviour
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.11.x
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
playback
Depends on:
Blocks:
 
 
Reported: 2012-09-15 12:36 UTC by Andreas Frisch
Modified: 2013-08-16 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
1.0 port patch for playbin-text example (1.41 KB, patch)
2012-09-19 14:58 UTC, Andreas Frisch
needs-work Details | Review
port playbin-text example to 1.0 api (1.98 KB, patch)
2012-09-19 15:30 UTC, Andreas Frisch
committed Details | Review
this version of playbin-text takes an optional third parameter for current-sink property (4.96 KB, text/x-csrc)
2012-09-19 17:31 UTC, Andreas Frisch
  Details
this version of playbin-text takes an optional third parameter for current-sink property (4.94 KB, text/x-csrc)
2013-08-16 11:14 UTC, Andreas Frisch
  Details

Description Andreas Frisch 2012-09-15 12:36:26 UTC
i have an appsink element in my application to handle subtitles proprietarily
the appsink caps include "text/x-raw" (which used to be "text/plain" in the 0.10 code)

now i set the appsink property of playbin to this appsink element
this way, i received the subtitle buffers emitted by subparse directly with my appsink element back in the 0.10.36 version

now, playbin complains that i'm missing a decoder for application/x-subtitle
Comment 1 Andreas Frisch 2012-09-19 14:58:11 UTC
Created attachment 224759 [details] [review]
1.0 port patch for playbin-text example
Comment 2 Tim-Philipp Müller 2012-09-19 15:04:15 UTC
Comment on attachment 224759 [details] [review]
1.0 port patch for playbin-text example

>-  g_signal_emit_by_name (appsink, "pull-buffer", &buffer);
>+  g_signal_emit_by_name (appsink, "pull-sample", &buffer);

This needs to go into a GstSample *sample; variable, and then you need to get the buffer from that with 

 buffer = gst_sample_get_buffer(sample);
Comment 3 Andreas Frisch 2012-09-19 15:30:39 UTC
Created attachment 224762 [details] [review]
port playbin-text example to 1.0 api
Comment 4 Tim-Philipp Müller 2012-09-19 15:42:50 UTC
Thanks, pushed:

commit 6dd83020292f44c105f00019b095914c734df527
Author: Andreas Frisch <fraxinas@opendreambox.org>
Date:   Wed Sep 19 17:29:01 2012 +0200

    tests: port playbin-text example to 1.0 api
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684084
Comment 5 Andreas Frisch 2012-09-19 17:31:35 UTC
Created attachment 224768 [details]
this version of playbin-text takes an optional third parameter for current-sink property

when compiling and trying this modified playbin-text testcase, it will fail when setting text stream 1 or 2  with this file: ftp://93.31.155.175/pub/RedFox/Plasma/DivXTest/DivXTest_v2/I_CONTAINERS/CONT-4F.mkv
Comment 6 Sebastian Dröge (slomo) 2013-08-16 10:30:04 UTC
Is this still a problem with latest git master?
Comment 7 Andreas Frisch 2013-08-16 11:13:35 UTC
it switches to the correct subtitle streams now!
had to modify the testcase a little bit so that it would play all the way through, though.
i'd consider it fixed!
Comment 8 Andreas Frisch 2013-08-16 11:14:07 UTC
Created attachment 251817 [details]
this version of playbin-text takes an optional third parameter for current-sink property