After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684064 - gjs-1.33.x fails to link with gold, needs explicit libffi dependency in PKG_CHECK_MODULES
gjs-1.33.x fails to link with gold, needs explicit libffi dependency in PKG_C...
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
1.33.x
Other Linux
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-15 05:05 UTC by Alexandre Rostovtsev
Modified: 2012-09-18 10:52 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
proposed patch (1.06 KB, patch)
2012-09-15 05:05 UTC, Alexandre Rostovtsev 		accepted-commit_now Details | Review

Description Alexandre Rostovtsev 2012-09-15 05:05:00 UTC 
In >=gobject-introspection-1.33.2, libffi was moved from Requires to Requires.private. Since gjs directly uses ffi functions, a missing PKG_CHECK_MODULES for libffi results in build failure when using GNU gold as the linker:

./.libs/libgjs.so: error: undefined reference to 'ffi_call'
collect2: error: ld returned 1 exit status
make[1]: *** [gjs-console] Error 1
Comment 1 Alexandre Rostovtsev 2012-09-15 05:05:56 UTC 
Created attachment 224382 [details] [review]
proposed patch

Trivial patch to configure.ac fixing the problem. OK to commit?
Comment 2 Colin Walters 2012-09-16 19:52:11 UTC 
Review of attachment 224382 [details] [review]:

Makes sense, thanks.  Please do add a link to this bug in the commit message.