After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683905 - Building gtk-doc fails
Building gtk-doc fails
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other All
: Normal critical
: ---
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-13 00:23 UTC by Jiro Matsuzawa
Modified: 2012-09-18 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
spanish corrections (17.40 KB, patch)
2012-09-18 00:09 UTC, Javier Hernández
none Details | Review
french corrections (26.99 KB, patch)
2012-09-18 00:55 UTC, Javier Hernández
committed Details | Review
a patch to fix tag (630 bytes, patch)
2012-09-18 09:44 UTC, Jiro Matsuzawa
committed Details | Review

Description Jiro Matsuzawa 2012-09-13 00:23:51 UTC
Building gtk-doc fails
It seems that es.po of the manual causes the failure.

The following is the log of jhbuild:
-------------------------------------------
% jhbuild buildone gtk-doc
*** Checking out gtk-doc *** [1/1]
git remote set-url origin git://git.gnome.org/gtk-doc
git remote update origin
Fetching origin
remote: Counting objects: 25, done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 18 (delta 9), reused 0 (delta 0)
Unpacking objects: 100% (18/18), done.
From git://git.gnome.org/gtk-doc
   f3c7a9a..5c2777d  master     -> origin/master
git pull --rebase
First, rewinding head to replay your work on top of it...
Fast-forwarded master to 5c2777d597121722e49afa3c41fd16cf5d01edb5.
*** Building gtk-doc *** [1/1]
make -j 8
Making all in help
make[1]: Entering directory `/opt/gnome/checkout/gtk-doc/help'
Making all in manual
make[2]: Entering directory `/opt/gnome/checkout/gtk-doc/help/manual'
  GEN    bn_IN/
  GEN    el/
  GEN    en_GB/
  GEN    es/es.mo
  GEN    de/
  GEN    fr/
  GEN    gu/
  GEN    sl/
  GEN    sv/
Warning: Could not merge translation for msgid:
You can also use <INCLUDE> ... </INCLUDE> to specify the #include files which are shown in the synopsis sections. It contains a comma-separate list of #include files, without the angle brackets. If you set it outside of any sections, it acts for all sections until the end of the file. If you set it within a section, it only applies to that section.
  GEN    ta/
  GEN    te/
  GEN    es/
Warning: Could not merge translation for msgid:
Use in the <link linkend="fdl-title-page">Title Page</link> (and on the covers, if any) a title distinct from that of the <link linkend="fdl-document">Document</link>, and from those of previous versions (which should, if there were any, be listed in the History section of the Document). You may use the same title as a previous version if the original publisher of that version gives permission.
Warning: Could not merge translation for msgid:
Preserve in that license notice the full lists of <link linkend="fdl-invariant"> Invariant Sections</link> and required <link linkend="fdl-cover-texts">Cover Texts</link> given in the <link linkend="fdl-document">Document's</link> license notice.
Warning: Could not merge translation for msgid:
You may add a passage of up to five words as a <link linkend="fdl-cover-texts">Front-Cover Text</link>, and a passage of up to 25 words as a <link linkend="fdl-cover-texts">Back-Cover Text</link>, to the end of the list of <link linkend="fdl-cover-texts">Cover Texts</link> in the <link linkend="fdl-modified">Modified Version</link>. Only one passage of Front-Cover Text and one of Back-Cover Text may be added by (or through arrangements made by) any one entity. If the <link linkend="fdl-document">Document</link> already includes a cover text for the same cover, previously added by you or by arrangement made by the same entity you are acting on behalf of, you may not add another; but you may replace the old one, on explicit permission from the previous publisher that added the old one.
Error: Could not merge translations:
'NoneType' object has no attribute 'node'
make[2]: *** [es/es.stamp] Error 1
make[2]: Leaving directory `/opt/gnome/checkout/gtk-doc/help/manual'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/gnome/checkout/gtk-doc/help'
make: *** [all-recursive] Error 1
*** Error during phase build of gtk-doc: ########## Error running make -j 8 *** [1/1]

  [1] Rerun phase build
  [2] Ignore error and continue to install
  [3] Give up on module
  [4] Start shell
  [5] Reload configuration
  [6] Go to phase "wipe directory and start over"
  [7] Go to phase "configure"
  [8] Go to phase "clean"
  [9] Go to phase "distclean"
choice:   
-------------------------------------------
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2012-09-13 15:24:33 UTC
This seems to be cause by the recent move to yelp-tools.
Comment 2 Kerrick Staley 2012-09-14 23:35:05 UTC
Reverting back to commit 6aa4fc26c3ee8617a687fa8f3c3a572fb9d52017 fixed this for me; it seems the error was introduced in 2daef6dee828fa95446891b556acb56d38067102.
Comment 3 Kerrick Staley 2012-09-14 23:38:29 UTC
You can temporarily fix the problem by selecting "[4] Start shell" in the "Build failed" menu, then running

git reset --hard 6aa4fc26c3ee8617a687fa8f3c3a572fb9d52017
exit

then selecting "[1] Rerun phase build" in the menu. You'll need to do this everytime you build anything that depends on gtk-doc.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2012-09-15 14:16:19 UTC
for convenience: http://git.gnome.org/browse/gtk-doc/commit/?id=2daef6dee828fa95446891b556acb56d38067102
Comment 5 Daniel Mustieles 2012-09-15 16:36:40 UTC
Sorry but I don't know how to fix it. The string seems to be correct, since there are no error in tags.

Also, I've updated mi local module with git pull, tried tu run ./autogen and maje -j 8, and it wors properly for me. I've compiled the module without any error.

Could you please tell me how to reproduce and/or fix this bug? I'm not using JHBuild, just running make directly, but it should be same, am I right?
Comment 6 Piotr Drąg 2012-09-15 18:00:35 UTC
Could it be the broken tags in Tamil translation I fixed yesterday?

http://git.gnome.org/browse/gtk-doc/commit/?id=ac15567adc5d2c4b381825d3b35dec6027d56ae9
Comment 7 André Klapper 2012-09-15 18:02:03 UTC
I just tried "jhbuild buildone -afc gtk-doc" and I also run into this.
Comment 8 Javier Hernández 2012-09-18 00:09:31 UTC
Created attachment 224564 [details] [review]
spanish corrections 

attaching spanish corrections
Comment 9 Javier Hernández 2012-09-18 00:55:55 UTC
Created attachment 224565 [details] [review]
french corrections

attaching french corrections
Comment 10 Javier Hernández 2012-09-18 02:01:17 UTC
I removed all "«" and "»" characters, fixed many tag typos and incoherent tags (ie: opening a <ulink> and closing with </link>) among many other changes.

Since I'm not a translator, I guess that these patches need a review from French and Spanish translation guys.


Cheers!
Comment 11 Jiro Matsuzawa 2012-09-18 06:36:28 UTC
Thank you for the patches.
Build succeeded after I applyed the patches.
However, I'm not sure if they have no translational problems as French or Spanish, too.

Thank you.
Comment 12 Alexandre Franke 2012-09-18 06:56:27 UTC
Speaking for French here as the team coordinator. Using " or ' instead of « and » is *NOT* ok in French. We use « and » everywhere else so that can't be the source of the issue anyway.

Also removing the French guillemets when there is no quotation mark in the original string doesn't seem to be necessary. We use them to indicate technical, non-French words. They shouldn't be a problem either.

The other changes in the patch (markup mismatch fixes) look ok.
Comment 13 Alexandre Franke 2012-09-18 06:57:36 UTC
Review of attachment 224565 [details] [review]:

Fixes things that are not broken (and the wrong way).
Comment 14 Luc Pi 2012-09-18 07:51:47 UTC
it should be a (non breakable) space before ':'

Seen at least here:

-msgstr "« Since »:"  <-----------(here it was already missing)
+msgstr "Since:"
 
-msgstr "« Deprecated » :"
+msgstr "Deprecated:"
 
-msgstr "« Returns » :"
+msgstr "Returns:"
Comment 15 Daniel Mustieles 2012-09-18 09:04:01 UTC
It isn't an error due to «» characters. The error was caused because there were several errors in tags.

I've fixed both Spanish and French translations, and it seems to work properly (Alexandre, I've left a fuzzy string in fr translation... please review and complete it. It has a missing tag, but I don't speak french, so I don't know how to translate it).

Please, test it in your JHBuild environments and, if you notice there is still a bug, please let me know to fix it.

In the other hand, I'm opening a bug against Pyg3t (gtxml component), because that tool has not been able to detect this kind of errors, and it should. Of course, if someone of you wants/can help with it, is welcome.

Javier, many thanks for your patches. Although they were not perfect, you have helped me a lot idetifying and fixing the error. I owe you a beer in the next GUADEC-ES at Madrid!! ;-)

Best regards.
Comment 16 Javier Hernández 2012-09-18 09:32:44 UTC
Hi all!

Since I'm not a translator I don't know which tags are allowed or not, so I just applied the same format as the original strings have and ensure that it builds fine. Sorry for the inconveniences.

Thanks for polishing the patches Daniel! I've just updated my git and your commits [1][2] made my JHBuild happy again. 

Anyway, I still see a warning:

"""
  GEN    fr/
Warning: Could not merge translation for msgid:
This License applies to any manual or other work that contains a notice placed by the copyright holder saying it can be distributed under the terms of this License. The <_:quote-1/>, below, refers to any such manual or work. Any member of the public is a licensee, and is addressed as <_:quote-2/>.
"""

Now that it builds again, I think my help isn't needed anymore :]

Daniel, I'll proudly accept that beer! ;)


Cheers!

[1]: http://git.gnome.org/browse/gtk-doc/commit/?id=a0c733300ece0765218b7055fdeb58e8a29927d5
[2]: http://git.gnome.org/browse/gtk-doc/commit/?id=36a554b8d282fbcf2d794b5278fa2830e16211a9
Comment 17 Jiro Matsuzawa 2012-09-18 09:44:26 UTC
Created attachment 224587 [details] [review]
a patch to fix tag

The attached patch will fix the following warning.

"""
  GEN    fr/
Warning: Could not merge translation for msgid:
This License applies to any manual or other work that contains a notice placed
by the copyright holder saying it can be distributed under the terms of this
License. The <_:quote-1/>, below, refers to any such manual or work. Any member
of the public is a licensee, and is addressed as <_:quote-2/>.
"""
Comment 18 Jiro Matsuzawa 2012-09-18 09:51:13 UTC
I've pushed it.
http://git.gnome.org/browse/gtk-doc/commit/?id=8c0b13bbc32c81d20c92a25d4f8c3688291fcf8b

I jhbuilded gtk-doc and there are no errors, no warnings.
Comment 19 Daniel Mustieles 2012-09-18 09:51:26 UTC
Review of attachment 224587 [details] [review]:

Patch commited
Comment 20 Daniel Mustieles 2012-09-18 09:51:49 UTC
Review of attachment 224565 [details] [review]:

Commited, with some changes
Comment 21 Daniel Mustieles 2012-09-18 09:52:14 UTC
Review of attachment 224565 [details] [review]:

Commited, with some changes
Comment 22 Daniel Mustieles 2012-09-18 09:53:43 UTC
Closing this bug, since everything seems to work properly.

Many thanks Jiro for your bug report, and Javier for his work with the patches.
Comment 23 Alexandre Franke 2012-09-18 14:13:30 UTC
(In reply to comment #15)
> (Alexandre, I've left a fuzzy string in fr translation... please review and
> complete it. It has a missing tag, but I don't speak french, so I don't know
> how to translate it).

Fixed, thanks.