After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683879 - region: Handle the case of an empty input sources list
region: Handle the case of an empty input sources list
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-12 15:50 UTC by Rui Matos
Modified: 2012-09-14 01:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: Handle the case of an empty input sources list (2.45 KB, patch)
2012-09-12 15:50 UTC, Rui Matos 		committed Details | Review
region: Create a source from the X layout in use when setting is empty (2.43 KB, patch)
2012-09-13 14:26 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-09-12 15:50:53 UTC 
Patch attached.
Comment 1 Rui Matos 2012-09-12 15:50:56 UTC 
Created attachment 224127 [details] [review]
region: Handle the case of an empty input sources list

We would end up in an endless loop on update.
Comment 2 Bastien Nocera 2012-09-12 16:04:52 UTC 
Review of attachment 224127 [details] [review]:

Looks good, but I don't want to see an empty list in the UI though.
Comment 3 Rui Matos 2012-09-13 14:26:10 UTC 
Created attachment 224227 [details] [review]
region: Create a source from the X layout in use when setting is empty

We don't want to show an empty input sources list so we create a
source from the current X layout in case the setting is empty.
Comment 4 Bastien Nocera 2012-09-13 15:06:57 UTC 
Review of attachment 224227 [details] [review]:

++
Comment 5 Rui Matos 2012-09-14 01:10:28 UTC 
Attachment 224127 [details] pushed as fb6881d - region: Handle the case of an empty input sources list
Attachment 224227 [details] pushed as 1e01925 - region: Create a source from the X layout in use when setting is empty