After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683865 - gst-launch segfaults when plugin is not correctly init'ed
gst-launch segfaults when plugin is not correctly init'ed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.11.x
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-12 12:09 UTC by Andreas Frisch
Modified: 2012-09-14 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbin: don't segfault in incorrectly init'ed plugins (1.44 KB, patch)
2012-09-12 12:13 UTC, Andreas Frisch 		committed Details | Review
playbin: don't segfault in incorrectly init'ed plugins, display error (962 bytes, patch)
2012-09-12 12:15 UTC, Andreas Frisch 		committed Details | Review

Description Andreas Frisch 2012-09-12 12:09:25 UTC 
after porting my elements from 0.10 to 1.0 api, i ran into crashes which were apparently caused by incorrect GST_PLUGIN_DEFINE / G_DEFINE_TYPE parameters in my plugin
stacktraces showed that the _is_renderer and _is_parser functions in gstsubtitleoverlay.c perfrom strstr in NULL strings in this case
another issue is in gst_element_factory_list_is_type
Comment 1 Andreas Frisch 2012-09-12 12:13:18 UTC 
Created attachment 224096 [details] [review]
playbin: don't segfault in incorrectly init'ed plugins
Comment 2 Andreas Frisch 2012-09-12 12:15:39 UTC 
Created attachment 224100 [details] [review]
playbin: don't segfault in incorrectly init'ed plugins, display error
Comment 3 Andreas Frisch 2012-09-12 12:16:24 UTC 
Comment on attachment 224096 [details] [review]
playbin: don't segfault in incorrectly init'ed plugins

patch for gstreamer (core)
Comment 4 Tim-Philipp Müller 2012-09-14 08:40:36 UTC 
commit 0bc87ee5d95beedd55207802a8c2926c1b98fabc
Author: Andreas Frisch <fraxinas@opendreambox.org>
Date:   Wed Sep 12 14:14:31 2012 +0200

    elementfactory: don't crash if no element klass has been set
    
    https://bugzilla.gnome.org/show_bug.cgi?id=683865


commit 6e469b2ac52b949ed1d1ffaad48c672bef6885e2
Author: Andreas Frisch <fraxinas@opendreambox.org>
Date:   Wed Sep 12 14:11:28 2012 +0200

    playbin: subtitleoverlay: don't segfault in incorrectly init'ed plugins
    
    https://bugzilla.gnome.org/show_bug.cgi?id=683865