After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683858 - codecparsers: vc1: fix aspect ratio calculation
codecparsers: vc1: fix aspect ratio calculation
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-12 09:37 UTC by Gwenole Beauchesne
Modified: 2012-09-12 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codecparsers: vc1: fix aspect ratio calculation (1.64 KB, patch)
2012-09-12 09:37 UTC, Gwenole Beauchesne 		committed Details | Review

Description Gwenole Beauchesne 2012-09-12 09:37:40 UTC 
Created attachment 224083 [details] [review]
codecparsers: vc1: fix aspect ratio calculation

Hi, ASPECT_HORIZ_SIZE and ASPECT_VERT_SIZE are syntax elements that hold binary encodings of sizes ranging from 1 to 256. Thus, the calculated pixel-aspect-ratio was off by one. Fix is in attachment.

I would also like to backport that to the 0.10 branch, should this interest anyone there.
Comment 1 Tim-Philipp Müller 2012-09-12 09:45:16 UTC 
commit 0b2dd2e72366f10d30581bf3758a640fb5e186ed
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Wed Sep 12 11:08:25 2012 +0200

    codecparsers: vc1: fix aspect ratio calculation.
    
    ASPECT_HORIZ_SIZE and ASPECT_VERT_SIZE are syntax elements that hold
    binary encodings of sizes ranging from 1 to 256. Thus, the calculated
    pixel-aspect-ratio was off by one.
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=683858
Comment 2 Tim-Philipp Müller 2012-09-12 09:47:43 UTC 
Comment on attachment 224083 [details] [review]
codecparsers: vc1: fix aspect ratio calculation

Also pushed to 0.10 branch.