After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683725 - Allow testing GDM login dialog from the session
Allow testing GDM login dialog from the session
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-10 13:51 UTC by Giovanni Campagna
Modified: 2012-10-23 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow testing GDM login dialog from the session (2.17 KB, patch)
2012-09-10 13:51 UTC, Giovanni Campagna
accepted-commit_now Details | Review

Description Giovanni Campagna 2012-09-10 13:51:35 UTC
Check an environment variable, GDM_GREETER_TEST. If 1, LoginDialog will
skip anything that fails outside a GDM session.
It is therefore possible to test the GDM greeter without installing it
system-wide, by attempting login as the already logged in user (uses the
same code path as the unlock dialog).
Comment 1 Giovanni Campagna 2012-09-10 13:51:39 UTC
Created attachment 223912 [details] [review]
Allow testing GDM login dialog from the session
Comment 2 Giovanni Campagna 2012-10-23 16:45:26 UTC
Hey, any chance this could be merged?
It is uncomfortable to cherry-pick this to each and every branch...
Comment 3 Colin Walters 2012-10-23 17:03:01 UTC
Review of attachment 223912 [details] [review]:

If it helps you, looks quite reasonable to me!
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-23 17:09:47 UTC
Review of attachment 223912 [details] [review]:

I'd prefer the lack of testing against the "1". Just having the envvar set should be enough.
Comment 5 Giovanni Campagna 2012-10-23 17:15:09 UTC
Too late, I just pushed it. Sorry.