After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683724 - NotificationDaemon: don't fail if a tray icon has no WM_CLASS
NotificationDaemon: don't fail if a tray icon has no WM_CLASS
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-10 13:44 UTC by Giovanni Campagna
Modified: 2012-09-10 16:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
NotificationDaemon: don't fail if a tray icon has no WM_CLASS (1019 bytes, patch)
2012-09-10 13:44 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-09-10 13:44:06 UTC 
If there is no WM_CLASS for a tray icon, it returns null, not the empty
string. Detect that case without an exception.
Comment 1 Giovanni Campagna 2012-09-10 13:44:09 UTC 
Created attachment 223911 [details] [review]
NotificationDaemon: don't fail if a tray icon has no WM_CLASS
Comment 2 Rui Matos 2012-09-10 16:12:17 UTC 
Review of attachment 223911 [details] [review]:

Looks good.
Comment 3 Giovanni Campagna 2012-09-10 16:40:40 UTC 
Attachment 223911 [details] pushed as 7ebb5c6 - NotificationDaemon: don't fail if a tray icon has no WM_CLASS