After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683628 - MessageTray: fix unexpanded height when receiving multiple telepathy messages
MessageTray: fix unexpanded height when receiving multiple telepathy messages
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-08 16:59 UTC by Giovanni Campagna
Modified: 2012-09-10 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
MessageTray: fix unexpanded height when receiving multiple telepathy messages (1.74 KB, patch)
2012-09-08 16:59 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-09-08 16:59:31 UTC
ClutterBinLayout is so amazingly broken: it uses the y_expand property to
find out if the children needs to honor alignment/fill, but that property is
"bubbled up" from the grand-children, so the notificationWidget would notice
the y_expand on the notificationBin (necessary to make the layout manager on
notificationWidget honor the alignment property for the bin), and would
receive the full height of the MessageTray actor from the parent's layout manager,
resulting in a notificationWidget shifting up, with the notification detached
from the screen.
Comment 1 Giovanni Campagna 2012-09-08 16:59:34 UTC
Created attachment 223812 [details] [review]
MessageTray: fix unexpanded height when receiving multiple telepathy messages
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-09-08 19:51:36 UTC
Fix ClutterBinLayout?
Comment 3 Giovanni Campagna 2012-09-08 20:48:44 UTC
Nah, it's one of the Clutter 2.0 "compatibility" cantfix.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-09-10 04:06:47 UTC
Review of attachment 223812 [details] [review]:

Works for me.
Comment 5 Giovanni Campagna 2012-09-10 08:42:04 UTC
Attachment 223812 [details] pushed as 9f48adc - MessageTray: fix unexpanded height when receiving multiple telepathy messages