After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683567 - Add new "Show Help window" to pad buttons mapping
Add new "Show Help window" to pad buttons mapping
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
3.5.x
Other Linux
: Normal enhancement
: ---
Assigned To: Olivier Fourdan
Control-Center Maintainers
Depends on: 679062 689599
Blocks:
 
 
Reported: 2012-09-07 11:56 UTC by Olivier Fourdan
Modified: 2012-12-20 10:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.06 KB, patch)
2012-09-07 11:59 UTC, Olivier Fourdan 		none Details | Review
Updated patch (1.22 KB, patch)
2012-10-04 16:53 UTC, Olivier Fourdan 		accepted-commit_after_freeze Details | Review
Updated patch (1.75 KB, patch)
2012-12-05 10:07 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2012-09-07 11:56:55 UTC 
Once bug 679062 which adds the OSD Help window is approved, this new action needs to be added to the list of actions in the UI as well.
Comment 1 Olivier Fourdan 2012-09-07 11:59:20 UTC 
Created attachment 223757 [details] [review]
Proposed patch
Comment 2 Olivier Fourdan 2012-10-04 16:53:14 UTC 
Created attachment 225829 [details] [review]
Updated patch
Comment 3 Bastien Nocera 2012-10-05 07:16:39 UTC 
Review of attachment 225829 [details] [review]:

You need to bump the gnome-settings-daemon req for the new enum. Looks fine to go in when the g-s-d patch does though.
Comment 4 Olivier Fourdan 2012-12-05 10:06:10 UTC 
Add dependency on libwacom 0.7 bug as well since we would not list the on-screen help action in the list of possible actions if the device does not have a layout in libwacom.
Comment 5 Olivier Fourdan 2012-12-05 10:07:44 UTC 
Created attachment 230745 [details] [review]
Updated patch

This patch uses the new libwacom 0.7 API to check if the device has a layout available and would not list the on-screen help as an action if no layout is provided by libwacom for that given device.