After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683433 - soup_header_parse_param_list() ought to return an empty GHashTable instead of NULL
soup_header_parse_param_list() ought to return an empty GHashTable instead of...
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: API
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
: 687099 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-05 16:05 UTC by Sergio Villar
Modified: 2012-10-29 18:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sergio Villar 2012-09-05 16:05:12 UTC 
It's easy to reproduce with empty headers. The problem is that parse_list() can return NULL and in that case soup_header_parse_param_list() also returns NULL.
Comment 1 Dan Winship 2012-10-29 12:01:25 UTC 
*** Bug 687099 has been marked as a duplicate of this bug. ***
Comment 2 Dan Winship 2012-10-29 12:08:21 UTC 
fixed in git
Comment 3 Paul Menzel 2012-10-29 14:13:15 UTC 
(In reply to comment #2)
> fixed in git

Thanks for the quick acting! This is commit c4ff1663 [1].

commit c4ff1663520f2167d274ac04cad7a88e9ba5902c
Author: Dan Winship <danw@gnome.org>
Date:   Mon Oct 29 08:05:01 2012 -0400

    soup_header_parse_param_list: return empty GHashTable instead of NULL
    
    Special-casing the "no parameters" case here complicates other code
    (eg, currently it causes warnings in SoupCache if you get an empty
    Cache-Control header).

Dan, it would be awesome, if you could always add the bug URL to the commit messages too.


[1] http://git.gnome.org/browse/libsoup/commit/?id=c4ff1663520f2167d274ac04cad7a88e9ba5902c
Comment 4 Dan Winship 2012-10-29 14:17:18 UTC 
Yeah, I normally do that, but I wasn't paying attention or something this time.
Comment 5 Paul Menzel 2012-10-29 16:26:19 UTC 
(In reply to comment #4)
> Yeah, I normally do that, but I wasn't paying attention or something this time.

No problem. Thanks again for the quick fix!
Comment 6 Paul Menzel 2012-10-29 16:27:40 UTC 
I just noticed that this issue’s state is still »UNCONFIRMED«. I do not know the policy. So it might be only get closed when a release has happened.
Comment 7 Dan Winship 2012-10-29 18:11:49 UTC 
oh, nope, I'm just used to git bz closing the bug automatically, which of course it didn't do because i forgot to include the bug url in the commit message...