After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683430 - CLUTTER_GESTURE_ACTION_GET_CLASS() calls G_TYPE_INSTANCE_GET_PRIVATE() instead of G_TYPE_INSTANCE_GET_CLASS()
CLUTTER_GESTURE_ACTION_GET_CLASS() calls G_TYPE_INSTANCE_GET_PRIVATE() instea...
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterAction
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-05 15:31 UTC by Emanuele Aina
Modified: 2012-09-11 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gesture-action: fix CLUTTER_GESTURE_ACTION_GET_CLASS() (1.53 KB, patch)
2012-09-05 15:32 UTC, Emanuele Aina 		committed Details | Review
action: fix CLUTTER_GESTURE_ACTION_GET_CLASS() (4.51 KB, patch)
2012-09-11 17:25 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2012-09-05 15:31:15 UTC 
There's an error probably due to cut'n'paste in clutter-gesture-action.h where CLUTTER_GESTURE_ACTION_GET_CLASS() is returning the instance private data instead of the class instance.
Comment 1 Emanuele Aina 2012-09-05 15:32:40 UTC 
Created attachment 223552 [details] [review]
gesture-action: fix CLUTTER_GESTURE_ACTION_GET_CLASS()

Fix a cut'n'paste error where CLUTTER_GESTURE_ACTION_GET_CLASS()
was returning the private class data instead of the class instance.
Comment 2 Emmanuele Bassi (:ebassi) 2012-09-05 15:35:06 UTC 
Review of attachment 223552 [details] [review]:

haha, ouch. :-)
Comment 3 Emmanuele Bassi (:ebassi) 2012-09-06 11:19:06 UTC 
Attachment 223552 [details] pushed as 609766f - gesture-action: fix CLUTTER_GESTURE_ACTION_GET_CLASS()
Comment 4 Emanuele Aina 2012-09-11 17:25:39 UTC 
Reopening, this time for ClickAction, PanAction, RotateAction and SwipeAction.
Comment 5 Emanuele Aina 2012-09-11 17:25:47 UTC 
Created attachment 224034 [details] [review]
action: fix CLUTTER_GESTURE_ACTION_GET_CLASS()

Fix the same cut'n'paste error fixed for GestureAction in 609766fa,
this time in ClickAction, PanAction, RotateAction and SwipeAction.
Comment 6 Emmanuele Bassi (:ebassi) 2012-09-11 19:45:25 UTC 
Review of attachment 224034 [details] [review]:

eh, copy and paste thinko.

looks good.