After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683264 - gsth264parser: fix Coverity found not initialized sps/pps valid member.
gsth264parser: fix Coverity found not initialized sps/pps valid member.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.23
Other Windows
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-03 12:07 UTC by Peter Seiderer
Modified: 2012-09-14 10:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gsth264parser: fix Coverity found not initialized sps/pps valid member. (963 bytes, patch)
2012-09-03 12:08 UTC, Peter Seiderer 		committed Details | Review
gsth264parse: add comment where return should be checked. (1.26 KB, patch)
2012-09-03 12:08 UTC, Peter Seiderer 		committed Details | Review

Description Peter Seiderer 2012-09-03 12:07:17 UTC 
Attached patch fixes Coverity found not initialized sps/pps valid members in gsth264praser.

Second patch shows where the parsing result of sps/pps is not checked for error the case.
Comment 1 Peter Seiderer 2012-09-03 12:08:03 UTC 
Created attachment 223285 [details] [review]
gsth264parser: fix Coverity found not initialized  sps/pps valid member.
Comment 2 Peter Seiderer 2012-09-03 12:08:46 UTC 
Created attachment 223286 [details] [review]
gsth264parse: add comment where return should be  checked.
Comment 3 Mark Nauwelaerts 2012-09-14 10:18:42 UTC 
commit 1af3833f1325b67e3b017c5b1c0c3c26324189c8
Author: Peter Seiderer <ps.report@gmx.net>
Date:   Mon Sep 3 13:58:22 2012 +0200

    gsth264parse: add comment where return should be checked.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=683264

commit a73957e01a8ea435dfb60e9949536e26997fd147
Author: Peter Seiderer <ps.report@gmx.net>
Date:   Mon Sep 3 13:43:03 2012 +0200

    gsth264parser: fix Coverity found not initialized sps/pps valid member.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=683264