After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683184 - [0.11] implement GST_EVENT_STREAM_CONFIG
[0.11] implement GST_EVENT_STREAM_CONFIG
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.11.x
Other Linux
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-01 23:37 UTC by Tim-Philipp Müller
Modified: 2012-09-24 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2012-09-01 23:37:58 UTC
subject says it all..
Comment 1 Olivier Crête 2012-09-04 17:51:20 UTC
I tried implementing it, but it was not trivial as expected as some elements (parsers, muxers) use the codec_data in their setcaps negotiation, so the whole thing can be quite entangled, etc. So implementing it in these elements requires understanding what exactly is going on. And since from the CAPS you can't know if there will be a stream-config event, it means that you have to wait until the first buffer to process the whole thing and possibly fail. Maybe the stream-config should instead be stashed in the GStructure of the CAPS event instead of being a separate event, something like gst_event_caps_set/parse_codec_data().


And in the current API (only having a codec_data buffers, etc), I'm not sure what the benefit is exactly. My use-case was to put profile-level-id in both caps (negotiated) and in the stream-config (declarative), but that requires putting arbitrary things in the GStructure in the event.
Comment 2 Wim Taymans 2012-09-11 14:34:02 UTC
commit 00c6fa74f5a0364ad67ddf15301f1d4d73fdad7a
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Tue Sep 11 16:29:12 2012 +0200

    events: remove STREAM_CONFIG
    
    We won't be able to implement this so it's better to move it out of the way.
Comment 3 Tim-Philipp Müller 2012-09-11 14:52:52 UTC
Thanks! Does it make sense to keep this bug around? It's not really something that we can change with the 1.0 API, is it? Unless we just add it in addition to the in-caps stuff, though I don't know what that would improve.