After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682955 - Support GStreamer 1.0
Support GStreamer 1.0
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.6.x (obsolete)
Other Windows
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-08-29 15:40 UTC by Dominique Leuenberger
Modified: 2013-09-13 01:08 UTC
See Also:
GNOME target: 3.6
GNOME version: ---


Attachments
Port to GStreamer 1.0 (1.29 KB, patch)
2012-08-29 16:05 UTC, Dominique Leuenberger
committed Details | Review

Description Dominique Leuenberger 2012-08-29 15:40:48 UTC
evolution/modules/audio-inline seems to be (from what I found so far) the only 'user' of gstreamer and does not make of weird APIs.

From my tests so far, changing configure to actually 'find' gstreamer 1.0 seems to be enough (which is in line with what is said on https://live.gnome.org/GnomeGoals/PortToGstreamer1 ).

I can spin up a patch, but would need some guidance which option is preferred:

a) 'ONLY' gstreamer-1.0: do no longer detect gstreamer-0.10 (a bit harsh, considering there is no code change)
b) 'AUTODETECT', priority on gsttreamer-1.0; if not found, try gstreamer-0.10
c) 'MANUAL/AUTO': have a --with-gstreamer-api=1.0|0.10 parameter, which overrides any automatic check; if not specified, AUTODETECT takes it's effects.

all of those are feasible and I would be able to provide patches for any of the solution in short time.
Comment 1 André Klapper 2012-08-29 16:04:31 UTC
...and for the records: http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/random/porting-to-0.11.txt
Comment 2 Dominique Leuenberger 2012-08-29 16:05:04 UTC
Created attachment 222803 [details] [review]
Port to GStreamer 1.0

Implementation dons as per option b:
- Detect GStreamer 1.0, if failed, try 0.10

No other code changes seem nescessary.
Comment 3 Dominique Leuenberger 2012-08-29 18:58:41 UTC
Also looked at the soft issue checklist referenced by Andre: no issues found.
Comment 4 Matthew Barnes 2012-08-31 12:07:42 UTC
Thanks for the patch!  I changed to error message to mention both versions, but otherwise looks good.

Fixed for Evolution 3.5.91 in:
http://git.gnome.org/browse/evolution/commit/?id=ad2ed55c74bf236ddc5d651b893f617ec3b9ce68