After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682925 - Get symbolic colors
Get symbolic colors
Status: RESOLVED NOTABUG
Product: gnome-control-center
Classification: Core
Component: Mouse
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-29 08:02 UTC by Ondrej Holy
Modified: 2013-04-21 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Ondrej Holy 2012-08-29 08:02:19 UTC
Get symbolic colors for Test Your Settings widget in gnome-mouse-test.c. Currently there are hardcoded colors.
Comment 1 Bastien Nocera 2012-08-29 10:40:15 UTC
Might need changes to Adwaita to export that colour.
Comment 2 Cosimo Cecchi 2012-08-29 14:12:05 UTC
What colors are these? I can't find any reference to colors in gnome-mouse-test.c in git master.
Comment 3 Ondrej Holy 2012-08-29 14:33:57 UTC
Sorry, It's not yet commited, patches are there:

https://bugzilla.gnome.org/show_bug.cgi?id=579135
Comment 4 Bastien Nocera 2012-12-11 08:23:13 UTC
Cosimo?
Comment 5 Cosimo Cecchi 2013-04-20 03:13:38 UTC
I am not sure using symbolic colors from the theme here really buys us much. The graphic style of the test area is pretty specific, as it has to match the colors of the SVG asset drawn inside, and I don't think you want the elements around it to change too much with the theme.
We also cannot really use or add generic style classes, as the widget is pretty unique.

In any case, if you still think it's a good idea, I can provide a patch, but it's not particularly pretty: we essentially need to add those color defines to the theme with a control-center specific name, use gtk_style_context_lookup_color() and fall back to the same gdk_rgba_parse() calls when those fail.
Comment 6 Allan Day 2013-04-21 12:00:38 UTC
(In reply to comment #5)
> I am not sure using symbolic colors from the theme here really buys us much.
> The graphic style of the test area is pretty specific, ...

I'm inclined to agree. Reopen if necessary.