After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682537 - Set the speed of the shield reveal from the speed of the mouse
Set the speed of the shield reveal from the speed of the mouse
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-23 13:11 UTC by Allan Day
Modified: 2012-11-06 22:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ScreenShield: account for motion velocity when hiding the lock screen (4.70 KB, patch)
2012-08-31 15:40 UTC, Giovanni Campagna 		committed Details | Review

Description Allan Day 2012-08-23 13:11:50 UTC 
It should feel like the shield is gaining momentum from the drag action that is used to pull it up.
Comment 1 Giovanni Campagna 2012-08-31 15:40:09 UTC 
Created attachment 223077 [details] [review]
ScreenShield: account for motion velocity when hiding the lock screen

Switch from a ClutterDragAction to a ClutterGestureAction, that gives
us the velocity of mouse motion at each step, and use it to compute the
animation time for completing the hide gesture.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-16 19:14:10 UTC 
Was this fixed? I swore a patch like this was landed.
Comment 3 Giovanni Campagna 2012-10-16 21:03:44 UTC 
Not that I'm aware of. And code still "tries to use the same speed regardless of original position", so no.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-11-06 20:37:01 UTC 
Review of attachment 223077 [details] [review]:

I'm quite sure this is going to need rebasing, but this looks fine to me.

::: js/ui/screenShield.js
@@ +374,3 @@
 
+function clamp(x, a, b) {
+    return Math.max(Math.min(x, b), a);

Could you copy the exact function from workspace.js?
Comment 5 Giovanni Campagna 2012-11-06 22:04:38 UTC 
Attachment 223077 [details] pushed as 797b1ff - ScreenShield: account for motion velocity when hiding the lock screen