After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682535 - Lock screen - don't show the pointer on the curtain until it is moved
Lock screen - don't show the pointer on the curtain until it is moved
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-23 13:03 UTC by Allan Day
Modified: 2012-11-06 22:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ScreenShield: hide the cursor while the lock screen is on (1.88 KB, patch)
2012-08-31 15:54 UTC, Giovanni Campagna 		reviewed Details | Review
ScreenShield: hide the cursor while the lock screen is on (1.58 KB, patch)
2012-11-06 22:06 UTC, Giovanni Campagna 		committed Details | Review

Description Allan Day 2012-08-23 13:03:26 UTC 
Always showing the pointer doesn't look great, it also doesn't fit with the idea that the machine is idle. It would be better to only show it after it has been moved, and to hide it after a short idle time.
Comment 1 Giovanni Campagna 2012-08-31 15:54:57 UTC 
Created attachment 223078 [details] [review]
ScreenShield: hide the cursor while the lock screen is on

While the screen is locked and the cursor is not moved, the mouse
cursor should be hidden, to indicate the machine is idle.
Comment 2 Ray Strode [halfline] 2012-08-31 16:05:36 UTC 
I think we should solve this more generally.  See bug 666121
Comment 3 Allan Day 2012-10-29 11:07:10 UTC 
(In reply to comment #2)
> I think we should solve this more generally.  See bug 666121

That seems like a good idea, but it seems like it needs more thought. In the mean time, this bug seems fairly straightforward. I don't see any harm in getting it fixed for now (but maybe I am ignorant :) ).
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-11-06 20:37:53 UTC 
Review of attachment 223078 [details] [review]:

::: js/ui/screenShield.js
@@ +848,2 @@
         this.actor.show();
+        if (this._state == State.FULL_SESSION)

Seems unrelated?
Comment 5 Giovanni Campagna 2012-11-06 22:06:59 UTC 
Created attachment 228316 [details] [review]
ScreenShield: hide the cursor while the lock screen is on

While the screen is locked and the cursor is not moved, the mouse
cursor should be hidden, to indicate the machine is idle.

Indeed it is unrelated. That was an old patch, and I had removed that bit
in a later rebase.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-11-06 22:09:06 UTC 
Review of attachment 228316 [details] [review]:

Sure.
Comment 7 Giovanni Campagna 2012-11-06 22:10:33 UTC 
Attachment 228316 [details] pushed as e5f7390 - ScreenShield: hide the cursor while the lock screen is on