GNOME Bugzilla – Bug 682475
App menu shows up in the lock screen
Last modified: 2012-11-17 02:25:52 UTC
When locking the screen, the app menu is hidden. However, we still allow to toggle the overview using the overlay-key - entering the overview has no visible effect, but after leaving it the app menu will be shown again. The 2nd patch should be enough to fix it (e.g. disable changes to the overview sate while the screen is locked), but conceptually both patches make sense to me (e.g. there might be other triggers for the app menu that I haven't thought of)
Created attachment 222152 [details] [review] appMenu: Make show() a no-op in locked state The app menu is hidden when entering the lock screen, however it might be shown again while the lock is still in place - we don't want this ever to be the case, so make show() a no-op while the screen is locked.
Created attachment 222153 [details] [review] overview: Disable toggling while locked While the screen is locked, entering and leaving the overview has no visible effect, so it is at best pointless - as Escape is used to "hide" the overview rather than raising the screen shield while the overview is "shown", it is even confusing. Just make sure that the overview state is kept while the screen lock is active by making show()/hide() no-ops.
Review of attachment 222152 [details] [review]: Makes sense
Review of attachment 222153 [details] [review]: I think this should be handled by blocking the keybinding in Main.globalKeyHandler
Comment on attachment 222152 [details] [review] appMenu: Make show() a no-op in locked state Attachment 222152 [details] pushed as 88effdd - appMenu: Make show() a no-op in locked state
I actually only needed patch #2 due to a local mutter patch, which (1) moves handling of the overlay key out of the globalKeyPress handler (2) makes the overlay-key available in the lock screen in the first place So at least for now, this is not an issue ...
I think all three of us have written the exact same patch with keybindings during modals.
(In reply to comment #7) > I think all three of us have written the exact same patch with keybindings > during modals. Asd. Very possible. Might make sense to collect them in a single bug.
Comment on attachment 222153 [details] [review] overview: Disable toggling while locked It was indeed a workaround for a local bug, rejecting.