After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682266 - Locales with empty %p have non-working controls
Locales with empty %p have non-working controls
Status: RESOLVED DUPLICATE of bug 673721
Product: gnome-control-center
Classification: Core
Component: Date and Time
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-20 13:50 UTC by Piotr Drąg
Modified: 2012-08-20 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Non-useful handles next to time (86.07 KB, image/png)
2012-08-20 13:50 UTC, Piotr Drąg
  Details
datetime: Do not offer the 12 hr clock in locales without AM/PM (2.66 KB, patch)
2012-08-20 14:01 UTC, Debarshi Ray
none Details | Review

Description Piotr Drąg 2012-08-20 13:50:53 UTC
Created attachment 221842 [details]
Non-useful handles next to time

Some locales (like pl or sv) have always empty %p (AM/PM) time variable. It results in strange, non-working controls in Date and Time panel. It would be nice to hide the arrows in this situation.
Comment 1 Debarshi Ray 2012-08-20 14:01:21 UTC
Created attachment 221849 [details] [review]
datetime: Do not offer the 12 hr clock in locales without AM/PM

I had offered this solution on a related bug sometime ago. Not sure what we want here, but anyway, just attaching it so that it does not get lost.
Comment 2 Piotr Drąg 2012-08-20 14:10:31 UTC
I understand that this patch hides both switches, not only the 12-hour one?

But anyway I don't think this is the right way to do it. Some people want to use 12-hour clock (even if it hasn't got AM/PM). Just hiding up and down buttons would be fine. I don't necessarily want to handle bug reports like "give me my option back!!1" ;)
Comment 3 Bastien Nocera 2012-08-20 14:21:13 UTC
In pl or sv, we can't show just show "0-12 : 0-59" for the time and expect the user to guess whether it's AM/PM. This is something we need to fix in some other parts of the system too. I would expect the configuration to carry on using 24h time for the configuration in pl and sv even if the time _display_ is made using 12h. In any case, it's dupe.

Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 673721 ***