GNOME Bugzilla – Bug 682248
Non-square tray items, insufficient horizontal padding
Last modified: 2012-09-02 17:21:04 UTC
Created attachment 221822 [details] screenshot and mockup with layout guidance The restyled tray has a few minor layout issues. In particular, the tray items are too close together, resulting in a non-square selection highlight. The selection highlight should be square, and added extra horizontal padding will give the tray items a bit more room to breath. A screenshot and layout guidance is attached.
Created attachment 223114 [details] [review] messageTray: Summary items should be square and have spacing
Review of attachment 223114 [details] [review]: Looks good.
Review of attachment 223114 [details] [review]: <magcius> rishi, "Since St.Widget does not honor the y-expand property of its children" <magcius> rishi, by default, St.Widget uses a ClutterFixedLayout <magcius> rishi, you probably want to switch it to use a ClutterBinLayout <magcius> rishi, by specifying the layout-manager property.
Created attachment 223128 [details] [review] messageTray: Summary items should be square and have spacing Changed the tray actor to use a ClutterBinLayout so that we don't need to hardcode the summaryBin height.
Review of attachment 223128 [details] [review]: Sure.
commit 69735940ec1519f5e9abbdcda6c43335cee69b86 Author: Debarshi Ray <debarshir@gnome.org> Date: Sat Sep 1 03:21:51 2012 +0200 messageTray: Summary items should be square and have spacing Each summary icon is 48x48 with a padding of 6px on each side. Thus, each summary item is 60px wide. Therefore the summary mode should be 60px high instead of 72px. Changed the tray actor to use a ClutterBinLayout so that it honors the y-expand property of its children. https://bugzilla.gnome.org/show_bug.cgi?id=682248
Created attachment 223201 [details] [review] messageTray: Summary items should not touch the edge of the monitor
Created attachment 223204 [details] [review] messageTray: Summary items should not touch the edge of the monitor Get rid of the padding values of #summary-mode, which makes no sense for the new tray, and use the .summary-source class instead.
Created attachment 223206 [details] [review] theme: Tweak the padding of #summary-mode Change the padding values of #summary-mode to be 6px on right and left to match the values in .summary-source, which determine the padding between the top and bottom edges of the tray and the items.
Review of attachment 223206 [details] [review]: Yes, this looks correct.
commit 3013a87bd251298e9ee58aef6633ff6660dbb6c8 Author: Debarshi Ray <debarshir@gnome.org> Date: Sun Sep 2 17:19:45 2012 +0200 theme: Tweak the padding of #summary-mode Change the padding values of #summary-mode to be 6px on right and left to match the values in .summary-source, which determine the padding between the top and bottom edges of the tray and the items. https://bugzilla.gnome.org/show_bug.cgi?id=682248