GNOME Bugzilla – Bug 682059
New button is missing internal padding
Last modified: 2012-08-17 10:02:30 UTC
It is currently too narrow, with the edges too close to the label. I'm pretty sure that this is a regression - the button used to be wider
Padding was achieved by adding trailing spaces in the New string. That's dirty, let's add padding directly in the button widget.
Created attachment 221540 [details] [review] Add an 8 pixel paddingon each side of the button Just added 8px on each side, don't know if it is right for you, there is only one line change, just modify the 8 with any number you want if it is not right.
The (In reply to comment #0) > I'm pretty sure that this is a regression - the button used to be wider Yes, previously we had a label with " New " (spaces included), but translators are not happt with this solution. Mael's patch is the right way to do it, but I cannot find any guideline on which is the right amount of padding... I checked a few apps (boxes, contacts, etc) and it seems everyone is doing it differently. Keep also in mind that in many languages the translation of "New" is not as short. Allan, could you suggest what size to use?
Created attachment 221562 [details] [review] patch It's cleaner to set a minimum size rather than specify padding. This way we can do it all within GtkButton, and we don't need to worry about longer strings when the label is translated.
Review of attachment 221562 [details] [review]: looks good!
Ok merged Allan's patch.