After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681733 - Warning reporting slightly inconsistent; trivial to fix
Warning reporting slightly inconsistent; trivial to fix
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: general
1.8.2
Other All
: Normal trivial
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2012-08-13 09:00 UTC by pilot_pirx
Modified: 2013-05-19 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PATCH: consistent jandling Errors and Warnings (167.21 KB, patch)
2013-05-01 13:16 UTC, albert
none Details | Review

Description pilot_pirx 2012-08-13 09:00:02 UTC
Most doxygen warnings include the string "warning: ", but some have it capitalized and some are missing it entirely (and are neither marked as "error:"). This makes grepping and counting the number of warnings a bit awkward. If the reporting were more consistent, the number of warnings could be determined correctly with 'fgrep -c'. As is, the number is slightly off.


Please s/Warning/warning/ in this message:

   file.c:42: Warning: include file foo.h not found, perhaps you forgot to add its directory to INCLUDE_PATH?


Please add "warning: " or "error: " to this message:

   file.c:42: Trying to add group FOO to itself!

These are the two that I encountered on my code, there may be more I haven't spotted yet.
Comment 1 albert 2013-05-01 13:16:29 UTC
Created attachment 242991 [details] [review]
PATCH: consistent jandling Errors and Warnings

This patch makes the handling of the errors and warnings a bit more consistent. When using the routines warn, warn_.... the text "Warning: " is automatically placed in front of the text. In case of the routine "err" the text "Error: " is automatically placed in front of the text.
In all calls to these routines the words like warning / error at the beginning of the text have been removed.
In case a call to "err" had the word "waring" as first word these calls have been replaced with a call to the new function warn_uncond (warn unconditionally).
In case a call to "err" had the word "notice" as first word these calls have been replaced with a call to the function msg.
Comment 2 Dimitri van Heesch 2013-05-11 14:37:08 UTC
Thanks, I'll include the patch in the next subversion update.
Comment 3 Dimitri van Heesch 2013-05-19 12:35:47 UTC
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.4. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.