After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681618 - display titlebar on modal dialogs
display titlebar on modal dialogs
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: WM theme
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-10 18:00 UTC by William Jon McCann
Modified: 2012-08-17 00:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
metacity: Add back titlebar of modal dialogs (1.91 KB, patch)
2012-08-10 18:18 UTC, Florian Müllner 		committed Details | Review
screenshot (379.71 KB, image/png)
2012-08-10 20:25 UTC, William Jon McCann 		  Details
metacity: Increase height of attached modals' titlebars (1.16 KB, patch)
2012-08-16 21:23 UTC, Florian Müllner 		committed Details | Review
metacity: Use rounded corners on attached modal dialogs (1.28 KB, patch)
2012-08-16 21:24 UTC, Florian Müllner 		committed Details | Review
metacity: Remove highlight on attached modals' titlebar (1.10 KB, patch)
2012-08-16 21:24 UTC, Florian Müllner 		committed Details | Review
Screenshot with patches applied (148.79 KB, image/png)
2012-08-16 21:24 UTC, Florian Müllner 		  Details

Description William Jon McCann 2012-08-10 18:00:22 UTC 
Now that we don't use the sheet style modal dialogs but instead center them I think it might be worth considering adding the titlebar back.

In many cases this helps identify the action required and affords an opportunity to move the windows (dialog+parent) - especially when the modal is larger than the parent.
Comment 1 Ray Strode [halfline] 2012-08-10 18:12:33 UTC 
A prerequisite to fixing this is to fix the modal dialogs in the wild we care about to:

1) set a window title
2) stop having a title in the content area of the window
Comment 2 Florian Müllner 2012-08-10 18:18:09 UTC 
Created attachment 220902 [details] [review]
metacity: Add back titlebar of modal dialogs
Comment 3 William Jon McCann 2012-08-10 20:25:30 UTC 
Created attachment 220909 [details]
screenshot

FYI, it looks like this with the patch.
Comment 4 Cosimo Cecchi 2012-08-11 00:39:04 UTC 
Review of attachment 220902 [details] [review]:

Patch looks good to me, if this is the desired look.
Comment 5 Florian Müllner 2012-08-16 21:23:58 UTC 
Created attachment 221476 [details] [review]
metacity: Increase height of attached modals' titlebars
Comment 6 Florian Müllner 2012-08-16 21:24:03 UTC 
Created attachment 221477 [details] [review]
metacity: Use rounded corners on attached modal dialogs
Comment 7 Florian Müllner 2012-08-16 21:24:08 UTC 
Created attachment 221478 [details] [review]
metacity: Remove highlight on attached modals' titlebar
Comment 8 Florian Müllner 2012-08-16 21:24:59 UTC 
Created attachment 221479 [details]
Screenshot with patches applied
Comment 9 Cosimo Cecchi 2012-08-17 00:40:48 UTC 
Review of attachment 221476 [details] [review]:

++
Comment 10 Cosimo Cecchi 2012-08-17 00:41:00 UTC 
Review of attachment 221477 [details] [review]:

++
Comment 11 Cosimo Cecchi 2012-08-17 00:41:11 UTC 
Review of attachment 221478 [details] [review]:

++
Comment 12 Florian Müllner 2012-08-17 00:45:29 UTC 
Attachment 220902 [details] pushed as 90795d2 - metacity: Add back titlebar of modal dialogs
Attachment 221476 [details] pushed as 8a38c74 - metacity: Increase height of attached modals' titlebars
Attachment 221477 [details] pushed as 8a4bbc4 - metacity: Use rounded corners on attached modal dialogs
Attachment 221478 [details] pushed as 944dfa2 - metacity: Remove highlight on attached modals' titlebar