After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681539 - shell: also destroy ignored items
shell: also destroy ignored items
Status: RESOLVED DUPLICATE of bug 686502
Product: gnome-shell
Classification: Core
Component: general
3.5.x
Other Linux
: Normal major
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-08-09 17:22 UTC by Alban Browaeys
Modified: 2012-11-21 22:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: also destroy ignored items (1.21 KB, patch)
2012-08-09 17:22 UTC, Alban Browaeys 		needs-work Details | Review

Description Alban Browaeys 2012-08-09 17:22:36 UTC 
Created attachment 220812 [details] [review]
shell: also destroy ignored items

Fix a loop introduced while fixing the async add items.
Appears when empathy contact list disappear (crash ?), the empathy-chat irc window triggers a loop into gnome-shell and a click on the application area in gnome-shell shows a list containing empty placeholders (except for the section titles), 
Patch that fixes the similar issue when adding items by me introduced this new issue (as I extended it too broadly to item removal). This one revert the removal part to its previous state.
Comment 1 Giovanni Campagna 2012-08-10 20:10:59 UTC 
Review of attachment 220812 [details] [review]:

currentItems.length includes all items (since it is derived from _getMenuItems()).
How the change corresponds to the commit subject?
Comment 2 Alban Browaeys 2012-08-11 09:55:19 UTC 
indeed I encountered the issue again (ie gnome-shell loop while empathy contact list disappear and empath-chat window stays with an application menu only containy in the popupmenu the submenu headers for chatrooms and contacts).
this issue thus is not fixed by the above change and needs more digging.
Thanks for the check. please do not commit. I will attempt to find the root of this bug (even if the context is hard to reproduce). If anybody manage to reproduce reliably the bug please add to the report. (ie I wonder if this only happens if empathy contact window crash or else)
Comment 3 Alban Browaeys 2012-11-21 19:06:12 UTC 
Finally I found a way to reproduce in a reliable way. That s a start.
with empathy roster + empathy chat + gnome shell.
When I restart gnome shell (or it crashed and spawned) if I switch to the empathy chat window before the roster one , I get a nearly empty app menu and then if I switch back to the roster window , gnome-shell "freeze"  . Ie it is not stuck but attempt really hard to build a menu but always get "action-added" from RemoteMenu._createMenuItem for most items.
Comment 4 Sjoerd Simons 2012-11-21 21:32:27 UTC 
Can you try the patch in #686502? It sounds like the same issue i've solved there
Comment 5 Alban Browaeys 2012-11-21 22:22:54 UTC 
applying patch from #686502 , fixes the freeze . Appmenu is still nearly empty when switching to the chat window before the roster one after a gnome-shell restart. But this last issue is not of the same level (minor and probably for the empathy side of things).

*** This bug has been marked as a duplicate of bug 686502 ***