After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 681153 - [0.11] default acquire_buffer function from GstBufferPool blocks forever
[0.11] default acquire_buffer function from GstBufferPool blocks forever
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-03 16:44 UTC by Arnaud Vrac
Modified: 2012-08-10 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Arnaud Vrac 2012-08-03 16:44:26 UTC 
When a buffer pool using the default acquire_function is configured with max_buffers > 0, two bugs can happen:

 - when min_buffers is 0, acquire_buffer will not try to allocate any buffer, and will wait forever.

 - when min_buffers > 0, acquire_buffer will not try to allocate any more buffers after min_buffers are allocated, instead of trying to allocate up to max_buffers.
Comment 1 Wim Taymans 2012-08-10 10:27:22 UTC 
commit fb78756679e76bc8fed4da7104a8b695562747e7
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Aug 10 12:23:03 2012 +0200

    bufferpool: fix max_buffers handling
    
    When max_buffers > 0 and the pool is empty, actually try to allocate more
    buffers up to the max_buffers limit.
    We need to add a counter for this to count how many buffers we allocated and
    check this against the max_buffers limit.
    Reorganise and clean up some code.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=681153