After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680803 - menubutton: Clear references in dispose, not finalize
menubutton: Clear references in dispose, not finalize
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-07-29 19:16 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-07-31 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
menubutton: Clear references in dispose, not finalize (1.87 KB, patch)
2012-07-29 19:16 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-07-29 19:16:56 UTC 
Nautilus crashes with a ref-counting bug where a menu button has been kept alive. This patch fixes it.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-07-29 19:16:59 UTC 
Created attachment 219861 [details] [review]
menubutton: Clear references in dispose, not finalize

We need to do this here so that an explicit gtk_widget_destroy
on either the widget or a container that holds it will kill the
reference to the menu or model.
Comment 2 Matthias Clasen 2012-07-30 06:54:24 UTC 
Review of attachment 219861 [details] [review]:

Makes sense, yes.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-07-31 15:10:01 UTC 
Attachment 219861 [details] pushed as 844e793 - menubutton: Clear references in dispose, not finalize