After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 680755 - Definition of fail is broken
Definition of fail is broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-28 15:49 UTC by Sjoerd Simons
Modified: 2012-07-30 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.21 KB, patch)
2012-07-28 15:49 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2012-07-28 15:49:33 UTC 
Created attachment 219791 [details] [review]
proposed patch

fail ("My error", 1); causes segfaults, patch attached
Comment 1 Tim-Philipp Müller 2012-07-30 16:17:24 UTC 
commit 8d9a4b2e94fa806f5146482fb0261d890db38fd5
Author: Sjoerd Simons <sjoerd@luon.net>
Date:   Sat Jul 28 17:33:52 2012 +0200

    check: unbreak fail #define
    
    The fail() definition was changed to not fail with non-GCC compilers,
    unfortunately the change was incorrect and appended the first argument
    of fail to the expression string instead of making it the message.
    
    This change does mean that fail() now requires a message to be passed
    along.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=680755
Comment 2 Tim-Philipp Müller 2012-07-30 16:22:28 UTC 
commit 71902797f22d8ba502cbdfbcc495f67b3b0cdb3c
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Mon Jul 30 17:21:10 2012 +0100

    tests: fix jifmux test for fixed fail()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=680755